Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

miri no longer builds after rust-lang/rust#76919 #77406

Closed
rust-highfive opened this issue Oct 1, 2020 · 4 comments · Fixed by rust-lang/miri#1568 or #77500
Closed

miri no longer builds after rust-lang/rust#76919 #77406

rust-highfive opened this issue Oct 1, 2020 · 4 comments · Fixed by rust-lang/miri#1568 or #77500
Assignees
Labels
A-miri Area: The miri tool C-bug Category: This is a bug.

Comments

@rust-highfive
Copy link
Collaborator

Hello, this is your friendly neighborhood mergebot.
After merging PR #76919, I observed that the tool miri has failing tests.
A follow-up PR to the repository https://github.com/rust-lang/miri is needed to fix the fallout.

cc @fusion-engineering-forks, do you think you would have time to do the follow-up work?
If so, that would be great!

And nominating for compiler team prioritization.

@rust-highfive rust-highfive added A-miri Area: The miri tool C-bug Category: This is a bug. labels Oct 1, 2020
@m-ou-se
Copy link
Member

m-ou-se commented Oct 1, 2020

Working on it!

@RalfJung
Copy link
Member

RalfJung commented Oct 1, 2020

@rust-lang/infra something odd happened with the notification here... the PR is by @m-ou-se, but the bot pinged @fusion-engineering-forks.

@m-ou-se
Copy link
Member

m-ou-se commented Oct 1, 2020

something odd happened with the notification here... the PR is by @m-ou-se, but the bot pinged @fusion-engineering-forks.

I sent the PR from a repository under fusion-engineering-forks. Looks like it uses the owner of the repo the PR came from, instead of the user that opened the PR.

@RalfJung
Copy link
Member

RalfJung commented Oct 3, 2020

Reopening until the submodule is bumped.

@RalfJung RalfJung reopened this Oct 3, 2020
@RalfJung RalfJung mentioned this issue Oct 3, 2020
@bors bors closed this as completed in 25c8c53 Oct 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-miri Area: The miri tool C-bug Category: This is a bug.
Projects
None yet
5 participants