Restore Servo’s style
crate in cargotest?
#79404
Labels
A-testsuite
Area: The testsuite used to check the correctness of rustc
T-infra
Relevant to the infrastructure team, which will review and decide on the PR/issue.
src/tools/cargotest
in this repository runscargo test
for a few crates as part of CI, including some of https://github.com/servo/servo/. This used to select theselectors
andstylo_tests
crates, whose dependency graph include most Servo crates that don’t rely on unstable language or std features.In #54451 (comment)
stylo_tests
was removed. This in turn greatly reduced the coverage of what ends up being compiled during this test, sincestylo_tests
depended on thestyle
crate which is one of the big components. With only theselectors
crate and its dependency graph, much less of Servo is compiled which makes including Servo incargotest
less useful. On the other hand, compiling more stuff might increase the time taken by CI.Some options here are:
style_tests
(notee
v.s.o
), which depends on thestyle
crate, to the crates being tested in order to restore test coverage to roughly what it was before rustc: Allow#[no_mangle]
anywhere in a crate #54451cargotest
in order to reduce CI time spent cloning a large repository only to compile a small part#[no_mangle]
anywhere in a crate #54451:rust/src/tools/cargotest/main.rs
Lines 48 to 49 in b387f62
The text was updated successfully, but these errors were encountered: