Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression 1.49: failing to infer generic param when not explicitly stated #79905

Closed
rylev opened this issue Dec 10, 2020 · 6 comments
Closed
Labels
A-inference Area: Type inference regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Milestone

Comments

@rylev
Copy link
Member

rylev commented Dec 10, 2020

Logs https://crater-reports.s3.amazonaws.com/beta-1.49-1/beta-2020-11-26/reg/traitgraph-0.1.0/log.txt

[INFO] [stdout] error[E0282]: type annotations needed
[INFO] [stdout]   --> src/algo/traversal.rs:92:35
[INFO] [stdout]    |
[INFO] [stdout] 92 |                 if *rank_entry == None.into() {
[INFO] [stdout]    |                                   ^^^^ cannot infer type for type parameter `T` declared on the enum `Option`

@rustbot modify labels: +regression-from-stable-to-beta

@rustbot rustbot added regression-from-stable-to-beta Performance or correctness regression from stable to beta. I-prioritize Issue: Indicates that prioritization has been requested for this issue. labels Dec 10, 2020
@Mark-Simulacrum Mark-Simulacrum added this to the 1.49.0 milestone Dec 10, 2020
@dillona
Copy link
Contributor

dillona commented Dec 11, 2020

searched nightlies: from nightly-2020-09-24 to nightly-2020-12-11
regressed nightly: nightly-2020-10-07
searched commits: from a1dfd24 to 98edd1f
regressed commit: 08e2d46

bisected with cargo-bisect-rustc v0.6.0

Host triple: aarch64-unknown-linux-gnu
Reproduce with:

cargo bisect-rustc

@Mark-Simulacrum
Copy link
Member

cc @matthewjasper @nikomatsakis -- looks like this is another bug due to #73905, but looks different from the one we're experimenting with a targeted patch for right now

@matthewjasper
Copy link
Contributor

Likely #77638

@Mark-Simulacrum
Copy link
Member

Hm ok, that seems reasonable then. Does it seem right to you to close as won't fix?

@matthewjasper
Copy link
Contributor

I think that's right

@camelid
Copy link
Member

camelid commented Dec 11, 2020

Closing as per simulacrum's and matthewjasper's comments.

@camelid camelid closed this as completed Dec 11, 2020
@camelid camelid added A-inference Area: Type inference T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. and removed I-prioritize Issue: Indicates that prioritization has been requested for this issue. labels Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-inference Area: Type inference regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

6 participants