Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression 1.49: warn/deny annotations after forbid annotation breaks build #79906

Closed
rylev opened this issue Dec 10, 2020 · 1 comment
Closed
Labels
regression-from-stable-to-beta Performance or correctness regression from stable to beta.

Comments

@rylev
Copy link
Member

rylev commented Dec 10, 2020

https://crater-reports.s3.amazonaws.com/beta-1.49-1/beta-2020-11-26/reg/zkp-criterion-utils-0.2.0/log.txt
https://crater-reports.s3.amazonaws.com/beta-1.49-1/beta-2020-11-26/reg/zkp-u256-0.2.0/log.txt
https://crater-reports.s3.amazonaws.com/beta-1.49-1/beta-2020-11-26/reg/as-dyn-trait-0.2.0/log.txt
https://crater-reports.s3.amazonaws.com/beta-1.49-1/beta-2020-11-26/reg/kmp-0.1.1/log.txt

[INFO] [stdout] error[E0453]: warn(unsafe_code) incompatible with previous forbid in same scope
[INFO] [stdout]   --> src/lib.rs:35:5
[INFO] [stdout]    |
[INFO] [stdout] 6  | #![forbid(unsafe_code)]
[INFO] [stdout]    |           ----------- `forbid` level set here
[INFO] [stdout] ...
[INFO] [stdout] 35 |     unsafe_code,
[INFO] [stdout]    |     ^^^^^^^^^^^

@rustbot modify labels: +regression-from-stable-to-beta

@rustbot rustbot added regression-from-stable-to-beta Performance or correctness regression from stable to beta. I-prioritize Issue: Indicates that prioritization has been requested for this issue. labels Dec 10, 2020
@rylev
Copy link
Member Author

rylev commented Dec 10, 2020

This was already reported in #77713 and is open to be reverted in #79903. Closing this as a duplicate.

@rylev rylev closed this as completed Dec 10, 2020
@jyn514 jyn514 removed the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression-from-stable-to-beta Performance or correctness regression from stable to beta.
Projects
None yet
Development

No branches or pull requests

3 participants