Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement MD5 in the digest module #8048

Closed
jedestep opened this issue Jul 25, 2013 · 9 comments
Closed

Implement MD5 in the digest module #8048

jedestep opened this issue Jul 25, 2013 · 9 comments

Comments

@jedestep
Copy link
Contributor

While binding to a wide variety of existing C reference implementations of MD5 is ok, I feel like MD5 is widely used enough that extra::digest really deserves a native implementation.

@JeffMurray
Copy link

From a totally new to Rust perspective:

I thought brson had a cripto-rust repo that includes an MD5, but I cant seem to find it at the moment. Not that I have figured out how to use those things yet,

I would like a native way to get an MD5 as well. I would even appreciate an example how to use a repo that looks like an interface. When I look at things like brsons cripto-rust repo or pcwalten's spidermonkeny interface, I do not know the steps to compile them.

@huonw
Copy link
Member

huonw commented Jul 26, 2013

@JeffMurray you may've been thinking of rustcrypto, which appears to just be wrapper around libcrypto for the hashes.

@zslayton
Copy link
Contributor

@huonw I'd like to work on this. Would I be stepping on anyone's toes?

@huonw
Copy link
Member

huonw commented Jul 28, 2013

@zslayton not that I know of, although @DaGenix (enix on IRC) has been working on the SHA ones.

@DaGenix
Copy link

DaGenix commented Jul 28, 2013

I'm actually planning on submitting a pull request tommorrow that includes an md5 implementation. I would certainly appreciate extra eyes for review / improvement. That request will also include much better support for future hash algorithms.

@kud1ing
Copy link

kud1ing commented Jul 29, 2013

See PR #8097

@kud1ing
Copy link

kud1ing commented Jul 29, 2013

@DaGenix
Copy link

DaGenix commented Aug 3, 2013

See PR #8272

@alexcrichton
Copy link
Member

Closing, we have decided to not distribute crypto code as part of the standard library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants