Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustdoc pub trait definition source #84825

Closed
Mark-Simulacrum opened this issue May 2, 2021 · 2 comments
Closed

rustdoc pub trait definition source #84825

Mark-Simulacrum opened this issue May 2, 2021 · 2 comments
Labels
regression-from-stable-to-stable Performance or correctness regression from one stable version to another. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@Mark-Simulacrum
Copy link
Member

e.g., the Hasher trait definition source, when expanded, contains "pub" in front of each function. This is not valid Rust, so likely is a bug somewhere.

Appears to have been a regression introduced between 1.49.0 and 1.50.0, based on the Hasher trait docs - https://doc.rust-lang.org/1.50.0/std/hash/trait.Hasher.html.
@Mark-Simulacrum Mark-Simulacrum added regression-from-stable-to-stable Performance or correctness regression from one stable version to another. T-rustdoc labels May 2, 2021
@rustbot rustbot added the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label May 2, 2021
@Stupremee
Copy link
Member

This seems to be the same error as #81274

@Mark-Simulacrum
Copy link
Member Author

Indeed, closing as duplicate.

@camelid camelid removed the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label May 6, 2021
@jyn514 jyn514 added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
regression-from-stable-to-stable Performance or correctness regression from one stable version to another. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@Mark-Simulacrum @jyn514 @camelid @Stupremee @rustbot