Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustdoc: Search results now have lines between them #85654

Closed
camelid opened this issue May 25, 2021 · 4 comments
Closed

rustdoc: Search results now have lines between them #85654

camelid opened this issue May 25, 2021 · 4 comments
Labels
A-rustdoc-ui Area: Rustdoc UI (generated HTML) C-bug Category: This is a bug. regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@camelid
Copy link
Member

camelid commented May 25, 2021

I'm not certain whether this is a bug or an intentional change, but I couldn't find any PRs that said they were making this change. There were two PRs merged recently that affected the search results display: #85551 and #85568. Cc @GuillaumeGomez.

beta (correct)

image

nightly (incorrect)

image
@camelid camelid added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. C-bug Category: This is a bug. A-rustdoc-ui Area: Rustdoc UI (generated HTML) labels May 25, 2021
@rustbot rustbot added the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label May 25, 2021
@jyn514
Copy link
Member

jyn514 commented May 25, 2021

I like the new version better.

@jhpratt
Copy link
Member

jhpratt commented May 25, 2021

This change appears to be intentional, as this line was added to CSS that only applies to this element.

@GuillaumeGomez
Copy link
Member

GuillaumeGomez commented May 25, 2021 •
edited
Loading

Yes, it's completely voluntary. We changed the display on mobile and to keep more coherent, we decided to keep the lines too. Closing this issue then. :)

@steffahn
Copy link
Member

@rustbot label -I-prioritize

@rustbot rustbot removed the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-rustdoc-ui Area: Rustdoc UI (generated HTML) C-bug Category: This is a bug. regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@GuillaumeGomez @jhpratt @steffahn @jyn514 @camelid @rustbot