Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: Option::insert and trait extensions conflict #85694

Closed
Mark-Simulacrum opened this issue May 25, 2021 · 4 comments
Closed

regression: Option::insert and trait extensions conflict #85694

Mark-Simulacrum opened this issue May 25, 2021 · 4 comments
Labels
regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Milestone

Comments

@Mark-Simulacrum
Copy link
Member

The breakage seems to come from extension traits in logos-derive (of various versions), from https://crater-reports.s3.amazonaws.com/beta-1.52-2/index.html.

See list there for the broken crates under the "regressed: dependencies (20 root crates, 1341 regressed crates in total)" and logos-derive headings.

@Mark-Simulacrum Mark-Simulacrum added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. regression-from-stable-to-beta Performance or correctness regression from stable to beta. labels May 25, 2021
@Mark-Simulacrum Mark-Simulacrum added this to the 1.53.0 milestone May 25, 2021
@rustbot rustbot added the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label May 25, 2021
@Mark-Simulacrum
Copy link
Member Author

@rust-lang/libs I haven't seen any feedback on this issue in the past ~20 days -- it is similar to #85667 in principle.

I suspect that as things stand we will close this as won't fix. I suspect there will not be an explicit note made in the release notes, either. We have until Wednesday ~morning to raise concerns with this path of action.

@m-ou-se
Copy link
Member

m-ou-se commented Jun 14, 2021

Oh, sorry about the lack of response. Without the I-nominated label, it doesn't show up in our agenda.

We should modify our agenda generator to include regressions (and a few other labels too, probably). (And/or maybe get some zulip bot like i've seen some other teams use.)

@yaahc
Copy link
Member

yaahc commented Jun 21, 2021

We should modify our agenda generator to include regressions (and a few other labels too, probably). (And/or maybe get some zulip bot like i've seen some other teams use.)

This is done now, so hopefully it won't be an issue again in the future.

I suspect that as things stand we will close this as won't fix. I suspect there will not be an explicit note made in the release notes, either. We have until Wednesday ~morning to raise concerns with this path of action.

This seems like a reasonable plan of action, though I wish we had a better way to deal with extension trait conflicts when adding new APIs...

@Mark-Simulacrum
Copy link
Member Author

Closing this out as it's no longer particularly actionable.

@apiraino apiraino removed the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

5 participants