Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustdoc: trait implementors sections contains duplicate entries #86630

Open
cynecx opened this issue Jun 25, 2021 · 6 comments
Open

rustdoc: trait implementors sections contains duplicate entries #86630

cynecx opened this issue Jun 25, 2021 · 6 comments
Labels
A-cross-crate-reexports Area: Documentation that has been re-exported from a different crate C-bug Category: This is a bug. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@cynecx
Copy link
Contributor

cynecx commented Jun 25, 2021 •
edited
Loading

Live: https://doc.rust-lang.org/nightly/std/iter/trait.IntoIterator.html#impl-IntoIterator-30

trait implementors sections contains duplicate entries (in the example below, the BinaryHeap impl appears twice)

image

rustdoc 1.55.0-nightly (7c3872e6b 2021-06-24)

Stable also has this issue.
@cynecx cynecx added the C-bug Category: This is a bug. label Jun 25, 2021
@jyn514
Copy link
Member

jyn514 commented Jun 26, 2021

One is std::BinaryHeap and the other is alloc::BinaryHeap. I don't know if there's a good way to avoid this with how rustdoc currently works; this seems like another good use case for rust-lang/rfcs#3011.

@jyn514 jyn514 added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Jun 26, 2021
@jyn514 jyn514 changed the title rustdoc (nightly): trait implementors sections contains duplicate entries rustdoc: trait implementors sections contains duplicate entries Jun 26, 2021
@jyn514 jyn514 added the A-cross-crate-reexports Area: Documentation that has been re-exported from a different crate label Jun 26, 2021
@jyn514
Copy link
Member

jyn514 commented Jun 26, 2021

I thought there was another issue open for this somewhere, but I can't seem to find it.

@poliorcetics

This comment was marked as off-topic.

Sign in to view
@poliorcetics

This comment was marked as off-topic.

Sign in to view
@jyn514
Copy link
Member

jyn514 commented Apr 7, 2022

! has the problem on nightly https://doc.rust-lang.org/nightly/std/primitive.never.html#blanket-implementations

This is a different issue, there's only one impl and nothing re-exports Never. Can you open a new issue?

@poliorcetics
Copy link
Contributor

Marked my comments as off-topic, see #96036 instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-cross-crate-reexports Area: Documentation that has been re-exported from a different crate C-bug Category: This is a bug. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cynecx @poliorcetics @jyn514