Skip to content

Main body width very narrow in firefox with min font size > default font size #93120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ijackson opened this issue Jan 20, 2022 · 3 comments
Closed
Assignees
Labels
A-rustdoc-ui Area: Rustdoc UI (generated HTML) C-bug Category: This is a bug. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@ijackson
Copy link
Contributor

Steps to reproduce

  1. Start Firefox 91.5.0esr from Debian buster (other versions may work too) with HOME pointing to a fresh empty directory, to get a default profile.
  2. Visit https://docs.rs/ureq/2.4.0/ureq/
  3. In firefox, in a new tab or window, visit about:preferences, enter "font" in the search box, click on "Advanced...". Set "Minimum font size" to "18". Note that the default proportional font size is "16" or for mono, "12".
  4. Observe that the main display column for the ureq docs is now absurdly narrow.

This is a regression (!)

This page https://docs.rs/vecdeque-stableix/1.0.0/vecdeque_stableix/ which was formatted a while ago with an older rustdoc, is fine.

Discussion

ISTM that this behaviour is undesirable and indeed unreasonable, and ought to be addressed in rustdoc. Particularly given that there is no UI in firefox which gives any kind of warning to the user who defines such an anomalous configuration.

I discovered this by visiting docs.rs and seeing misformatted docs. My browser configuration has not changed recently so I must have had this anomalous setting for some time, and by and large I find that most websites do work. I was only able to narrow down the reproducer by comparing different browser profiles and experimenting in about:config with font stuff (I had a hunch it might be relevant).

Screenshot

Screenshot

@ijackson ijackson added the C-bug Category: This is a bug. label Jan 20, 2022
@ijackson
Copy link
Contributor Author

@rustbot modify labels +T-rustdoc

@rustbot rustbot added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Jan 20, 2022
@jsha jsha self-assigned this Jan 21, 2022
@jsha jsha added the A-rustdoc-ui Area: Rustdoc UI (generated HTML) label Jan 21, 2022
@jsha
Copy link
Contributor

jsha commented Jan 21, 2022

Thanks for the report! Also being discussed at https://github.com/rust-lang/docs.rs/issues/1607, though we should move that conversation over here since this is a rustdoc issue rather than a docs.rs issue.

@jsha
Copy link
Contributor

jsha commented Jan 21, 2022

Actually, closing in favor of the other issue, which is now moved into the rust repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rustdoc-ui Area: Rustdoc UI (generated HTML) C-bug Category: This is a bug. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

3 participants