Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

regression: stack overflow in InvocationCollector #94509

Closed
Mark-Simulacrum opened this issue Mar 1, 2022 · 6 comments
Closed

regression: stack overflow in InvocationCollector #94509

Mark-Simulacrum opened this issue Mar 1, 2022 · 6 comments
Labels
regression-from-stable-to-stable Performance or correctness regression from one stable version to another. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Milestone
1.60.0

Comments

@Mark-Simulacrum
Copy link
Member

Mark-Simulacrum commented Mar 1, 2022 •
edited
Loading

Crater picked up this issue in:

https://crater-reports.s3.amazonaws.com/beta-1.60-1/beta-2022-02-22/reg/k2_tree-0.5.2/log.txt
@Mark-Simulacrum Mark-Simulacrum changed the title regression: stack overflow regression: stack overflow in InvocationCollector Mar 1, 2022
@Mark-Simulacrum Mark-Simulacrum added regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 1, 2022
@rustbot rustbot added the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label Mar 1, 2022
@Mark-Simulacrum Mark-Simulacrum added this to the 1.60.0 milestone Mar 1, 2022
@apiraino
Copy link
Contributor

apiraino commented Mar 3, 2022

addtional info: the crate compiles fine on beta, the crate's tests fail. To reproduce:

$ rustc +beta --version
rustc 1.60.0-beta.1 (0a4f984a8 2022-02-22)
$ cargo +beta test

Upgrading the dependency crate bitvec (v0.17.4 -> v1.0.0), will cause the crate to stop compiling.

@estebank
Copy link
Contributor

estebank commented Mar 4, 2022

CC @myrrlyn, just in case

@myrrlyn
Copy link

myrrlyn commented Mar 4, 2022

… weird

has crater failed any of my builds?

@apiraino
Copy link
Contributor

I think I cannot reproduce this anymore on {nightly,beta,stable}.

@pietroalbini pietroalbini added regression-from-stable-to-stable Performance or correctness regression from one stable version to another. and removed regression-from-stable-to-beta Performance or correctness regression from stable to beta. labels Jun 24, 2022
@apiraino
Copy link
Contributor

apiraino commented Jul 4, 2022

this is now on stable. I could not pinpoint a specific moment it started. For the record, the bisection points to nightly-2022-01-18 and mentions these rollups:

found 6 bors merge commits in the specified range
  commit[0] 2022-01-16UTC: Auto merge of #92970 - matthiaskrgr:rollup-tcx7cfb, r=matthiaskrgr
  commit[1] 2022-01-16UTC: Auto merge of #92935 - Xanewok:update-rls, r=pietroalbini
  commit[2] 2022-01-17UTC: Auto merge of #92473 - petrochenkov:ltrattr2, r=Aaron1011
  commit[3] 2022-01-17UTC: Auto merge of #92996 - matthiaskrgr:rollup-50wpzva, r=matthiaskrgr
  commit[4] 2022-01-17UTC: Auto merge of #92816 - tmiasko:rm-llvm-asm, r=Amanieu
  commit[5] 2022-01-17UTC: Auto merge of #90986 - camsteffen:nested-filter, r=cjgillot
ERROR: no commits between bd3cb52565faab2755ff1bdb54d88bc91f47b4b9 and 
ee5d8d37baaf5b5a81a98396952839c73ae41c68 within last 167 days

@apiraino
Copy link
Contributor

Hope it's fine to close this as I cannot reproduce anymore on stable.

@rustbot label -I-prioritize

@rustbot rustbot removed the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
regression-from-stable-to-stable Performance or correctness regression from one stable version to another. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.60.0
Development

No branches or pull requests
6 participants
@estebank @pietroalbini @Mark-Simulacrum @myrrlyn @apiraino @rustbot