Skip to content

[NLL] Loss of 'static relaxation suggestion under NLL #95701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jackh726 opened this issue Apr 5, 2022 · 2 comments · Fixed by #97284
Closed

[NLL] Loss of 'static relaxation suggestion under NLL #95701

jackh726 opened this issue Apr 5, 2022 · 2 comments · Fixed by #97284
Labels
A-diagnostics Area: Messages for errors, warnings, and lints A-NLL Area: Non-lexical lifetimes (NLL) NLL-diagnostics Working towards the "diagnostic parity" goal T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@jackh726
Copy link
Member

jackh726 commented Apr 5, 2022 •
edited
Loading

In the src/test/ui/suggestions/impl-on-dyn-trait-with-implicit-static-bound.rs test, we give the suggestion consider relaxing the implicit `'static` requirement under migrate mode. Under NLL, we lose that suggestion, and have a slightly less user-friendly error message.

Importantly, with the suggestion, the code is rustfix-able. Without the suggestion, it is not.
@jackh726 jackh726 added A-diagnostics Area: Messages for errors, warnings, and lints T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. A-NLL Area: Non-lexical lifetimes (NLL) NLL-diagnostics Working towards the "diagnostic parity" goal labels Apr 5, 2022
@b-naber
Copy link
Contributor

b-naber commented May 19, 2022

@jackh726 Is this a blocker for removing migrate mode?

@jackh726
Copy link
Member Author

In my opinion, no. It's just a suggestion.

@b-naber b-naber mentioned this issue May 22, 2022
Merged
@bors bors closed this as completed in ed76b77 May 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-diagnostics Area: Messages for errors, warnings, and lints A-NLL Area: Non-lexical lifetimes (NLL) NLL-diagnostics Working towards the "diagnostic parity" goal T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add suggestion for relaxing static lifetime bounds on dyn trait impls in NLL b-naber/rust
2 participants
@jackh726 @b-naber