Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rls no longer builds after rust-lang/rust#98975 #99234

Closed
rust-highfive opened this issue Jul 14, 2022 · 4 comments · Fixed by #99246
Closed

rls no longer builds after rust-lang/rust#98975 #99234

rust-highfive opened this issue Jul 14, 2022 · 4 comments · Fixed by #99246
Assignees
Labels
C-bug Category: This is a bug.

Comments

@rust-highfive
Copy link
Collaborator

Hello, this is your friendly neighborhood mergebot.
After merging PR #98975, I observed that the tool rls no longer builds.
A follow-up PR to the repository https://github.com/rust-lang/rls is needed to fix the fallout.

cc @jyn514, do you think you would have time to do the follow-up work?
If so, that would be great!

@rust-highfive rust-highfive added A-rls C-bug Category: This is a bug. labels Jul 14, 2022
@jyn514
Copy link
Member

jyn514 commented Jul 14, 2022

Yes, I think I'll have time to fix this today.

@jyn514
Copy link
Member

jyn514 commented Jul 14, 2022

I think there are other changes that need to happen first. I tried to compile with tonight's nightly and got lots of errors from rustfmt:

error[E0532]: expected unit struct, unit variant or constant, found tuple variant `ast::Extern::Implicit`
   --> /home/jnelson/.local/lib/cargo/git/checkouts/rustfmt-c4b65366788d3254/5fa2727/src/utils.rs:141:9
    |
141 |         ast::Extern::Implicit => "C".to_owned(),
    |         ^^^^^^^^^^^^^^^^^^^^^

@Xanewok do you know what could be going wrong? do I need to update rustfmt or something like that?

@Xanewok
Copy link
Member

Xanewok commented Jul 14, 2022

I pushed the latest update at rust-lang/rls@ac4648b. @jyn514 is the failure above from the x.py test build here or in the RLS repo?

Rustfmt should be vendored here and should work as expected IIUC.

@Xanewok Xanewok mentioned this issue Jul 14, 2022
@jyn514
Copy link
Member

jyn514 commented Jul 14, 2022

@Xanewok that's in the RLS repo.

@bors bors closed this as completed in 8e3dd62 Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants