Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move pal cfgs in f32 and f64 to sys #108485

Merged
merged 1 commit into from
Jul 10, 2023
Merged

Conversation

devsnek
Copy link
Contributor

@devsnek devsnek commented Feb 26, 2023

I'd like to push forward on sys being a separate crate. To start with, most of these PAL exception cases are very simple little bits of code like this, so I thought I would try tidying them up.

@rustbot
Copy link
Collaborator

rustbot commented Feb 26, 2023

r? @cuviper

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Feb 26, 2023
@rustbot
Copy link
Collaborator

rustbot commented Feb 26, 2023

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

library/std/src/f64.rs Outdated Show resolved Hide resolved
library/std/src/f32.rs Outdated Show resolved Hide resolved
library/std/src/sys/mod.rs Outdated Show resolved Hide resolved
@programmerjake
Copy link
Member

note that you should mark the new functions your creating as #[inline] to match the functions they're getting split out of.

@workingjubilee
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Mar 8, 2023

📌 Commit 27ee670 has been approved by workingjubilee

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 8, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 8, 2023
…kingjubilee

move pal cfgs in f32 and f64 to sys

I'd like to push forward on `sys` being a separate crate. To start with, most of these PAL exception cases are very simple little bits of code like this, so I thought I would try tidying them up.
@matthiaskrgr
Copy link
Member

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 9, 2023
@devsnek devsnek removed the request for review from thomcc March 18, 2023 03:58
@bors
Copy link
Contributor

bors commented Mar 19, 2023

☔ The latest upstream changes (presumably #109346) made this pull request unmergeable. Please resolve the merge conflicts.

@cuviper
Copy link
Member

cuviper commented Mar 23, 2023

You should probably rebase and squash this, but I'll leave the review to:

r? @workingjubilee

@rustbot rustbot assigned workingjubilee and unassigned cuviper Mar 23, 2023
@devsnek
Copy link
Contributor Author

devsnek commented Apr 30, 2023

@workingjubilee bump

@workingjubilee
Copy link
Member

Oh, sorry! Yes, please squash and then I will approve.

@bors
Copy link
Contributor

bors commented May 10, 2023

☔ The latest upstream changes (presumably #111401) made this pull request unmergeable. Please resolve the merge conflicts.

@Dylan-DPC
Copy link
Member

@devsnek can you resolve the conflicts and squash the commits? thanks

@rustbot rustbot added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Jul 10, 2023
@workingjubilee
Copy link
Member

I took care of the conflicts and rebased this.
@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jul 10, 2023

📌 Commit 45b516c has been approved by workingjubilee

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 10, 2023
@bors
Copy link
Contributor

bors commented Jul 10, 2023

⌛ Testing commit 45b516c with merge 71f71a5...

@bors
Copy link
Contributor

bors commented Jul 10, 2023

☀️ Test successful - checks-actions
Approved by: workingjubilee
Pushing 71f71a5 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 10, 2023
@bors bors merged commit 71f71a5 into rust-lang:master Jul 10, 2023
@rustbot rustbot added this to the 1.73.0 milestone Jul 10, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (71f71a5): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
4.1% [4.1%, 4.1%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
3.2% [3.2%, 3.2%] 1
Regressions ❌
(secondary)
2.3% [1.2%, 3.0%] 5
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-2.0% [-2.2%, -1.9%] 2
All ❌✅ (primary) 3.2% [3.2%, 3.2%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
0.0% [0.0%, 0.0%] 3
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 0.0% [0.0%, 0.0%] 3

Bootstrap: 657.826s -> 658.446s (0.09%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.