-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move pal cfgs in f32 and f64 to sys #108485
Conversation
r? @cuviper (rustbot has picked a reviewer for you, use r? to override) |
Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
53b2675
to
5309135
Compare
note that you should mark the new functions your creating as |
@bors r+ |
…kingjubilee move pal cfgs in f32 and f64 to sys I'd like to push forward on `sys` being a separate crate. To start with, most of these PAL exception cases are very simple little bits of code like this, so I thought I would try tidying them up.
27ee670
to
91f9e09
Compare
☔ The latest upstream changes (presumably #109346) made this pull request unmergeable. Please resolve the merge conflicts. |
You should probably rebase and squash this, but I'll leave the review to: |
@workingjubilee bump |
Oh, sorry! Yes, please squash and then I will approve. |
☔ The latest upstream changes (presumably #111401) made this pull request unmergeable. Please resolve the merge conflicts. |
@devsnek can you resolve the conflicts and squash the commits? thanks |
fd11e1a
to
45b516c
Compare
I took care of the conflicts and rebased this. |
☀️ Test successful - checks-actions |
Finished benchmarking commit (71f71a5): comparison URL. Overall result: ❌ regressions - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Bootstrap: 657.826s -> 658.446s (0.09%) |
I'd like to push forward on
sys
being a separate crate. To start with, most of these PAL exception cases are very simple little bits of code like this, so I thought I would try tidying them up.