Wrap the whole LocalInfo in ClearCrossCrate. #108944

cjgillot · 2023-03-09T17:49:08Z

MIR contains a lot of information about locals. The primary purpose of this information is the quality of borrowck diagnostics.

This PR aims to drop this information after MIR analyses are finished, ie. starting from post-cleanup runtime MIR.

bors · 2023-03-09T17:49:30Z

⌛ Trying commit 345a9749c71bab291a3ffb43e0194342ae11291a with merge a2523b11c11aa554813e8ecc01272e3bb92ba1d2...

cjgillot · 2023-03-10T13:22:26Z

@bors try @rust-timer queue

rust-timer · 2023-03-10T17:33:30Z

Finished benchmarking commit (d6008dafc64975183e3a82d2e5083652a5f4c404): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.5%	[1.1%, 1.9%]	5
Regressions ❌ (secondary)	1.9%	[1.1%, 2.9%]	15
Improvements ✅ (primary)	-0.8%	[-1.3%, -0.2%]	61
Improvements ✅ (secondary)	-1.0%	[-2.6%, -0.4%]	12
All ❌✅ (primary)	-0.6%	[-1.3%, 1.9%]	66

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.1%	[1.1%, 3.1%]	3
Improvements ✅ (primary)	-1.4%	[-3.5%, -0.1%]	27
Improvements ✅ (secondary)	-2.4%	[-4.0%, -0.8%]	18
All ❌✅ (primary)	-1.4%	[-3.5%, -0.1%]	27

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.5%	[1.5%, 1.5%]	2
Regressions ❌ (secondary)	2.6%	[2.2%, 3.6%]	9
Improvements ✅ (primary)	-1.2%	[-1.4%, -1.1%]	4
Improvements ✅ (secondary)	-2.0%	[-2.0%, -2.0%]	1
All ❌✅ (primary)	-0.3%	[-1.4%, 1.5%]	6

cjgillot · 2023-03-10T18:08:52Z

Perf: ~0.8% improvement in instruction count, driven by reduced crate metadata encoding/decoding (crate_metadata -1.8%).
Two outliers: unicode-normalization (more calls to relate) and ucd (more calls to coerce_unsized). I don't understand yet why.

r? compiler

rustbot · 2023-03-10T18:12:11Z

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

oli-obk · 2023-03-10T18:22:41Z

clippy tests also need some blessing.

r? @oli-obk

bors · 2023-03-15T18:57:03Z

📌 Commit 2adf2cd has been approved by oli-obk

It is now in the queue for this repository.

bors · 2023-03-16T19:59:59Z

⌛ Testing commit 2adf2cd with merge 511364e...

bors · 2023-03-16T22:47:36Z

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing 511364e to master...

rust-timer · 2023-03-17T21:50:39Z

Finished benchmarking commit (511364e): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.6%	[0.3%, 2.4%]	6
Regressions ❌ (secondary)	1.7%	[1.0%, 2.9%]	16
Improvements ✅ (primary)	-0.8%	[-1.3%, -0.5%]	45
Improvements ✅ (secondary)	-0.8%	[-0.8%, -0.7%]	5
All ❌✅ (primary)	-0.5%	[-1.3%, 2.4%]	51

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.5%	[2.5%, 2.5%]	1
Regressions ❌ (secondary)	2.0%	[1.0%, 3.0%]	5
Improvements ✅ (primary)	-1.2%	[-2.1%, -0.7%]	12
Improvements ✅ (secondary)	-2.8%	[-3.3%, -1.3%]	9
All ❌✅ (primary)	-0.9%	[-2.1%, 2.5%]	13

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.9%	[1.6%, 2.2%]	4
Regressions ❌ (secondary)	2.6%	[2.2%, 3.3%]	10
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	1.9%	[1.6%, 2.2%]	4

cjgillot · 2023-03-18T10:09:23Z

Perf report : identical to #108944 (comment)
The improvement is in crate metadata size, on average -1.8% up to 5%.

nnethercote · 2023-03-19T05:34:54Z

A lot of movement in many metrics in those results. Cycles and wall-time look a little worse than instruction counts, like they are slight regressions overall. Results in secondary benchmarks are worse than primary benchmarks (which is better than the other way around). But binary size reductions are quite high on numerous benchmarks. I guess overall you could say all of this balances out.

pnkfelix · 2023-03-21T17:29:32Z

primary instruction count regression was to unicode normalization (5 variations in [1.5%, 2.4%] range). Slightly more muted for cycle count and wall time there.
as noted by @lqd and @nnethercote on PR comments: crate metadata + binary size improved all around.
overall this is a win
marking as triaged.

@rustbot label: +perf-regression-triaged

Update the toolchain to use nightly-2023-04-16. Changes were related to the following changes to the toolchain: - rust-lang/rust#108944 - rust-lang/rust#108148 - rust-lang/rust#108471 - rust-lang/rust#109358 - rust-lang/rust#109849 - rust-lang/rust#109819 - rust-lang/rust#109718 - rust-lang/rust#109092 - rust-lang/rust#108856 - rust-lang/rust#105613 - rust-lang/rust#103042 - rust-lang/rust#109716 - rust-lang/rust#108340 - rust-lang/rust#102906 - rust-lang/rust#98112 - rust-lang/rust#108080

…=oli-obk" This reverts commit 511364e, reversing changes made to e386217.

ryoqun · 2023-05-26T14:08:23Z

@cjgillot hi, it seems that this pr introduced some clippy false-positves of redundant_clone.

namely, rust-lang/rust-clippy#10577 and rust-lang/rust-clippy#10517 (added testcases)

and maybe this too: rust-lang/rust-clippy#10545

I concluded this bisect with this branch: https://github.com/rust-lang/rust/compare/master...ryoqun:rust:clippy-redundant-clone-false-positives?expand=1

and this command:

./x.py clean && ./x.py test src/tools/clippy

seems bunch of nightly clippy users are noticing likewise. so i think there will be more after 1.70 is released?

(EDIT: i also checked latest nightly 2023-05-26 is still affected as well)

oli-obk · 2023-05-26T14:37:26Z

This needs to be fixed on the clippy side. We must have been using the LocalInfo mistakenly in the clippy lint

Move `redundant_clone` to `nursery` changelog: [`redundant_clone`]: Move to `nursery` A bunch of FPs in `redundant_clone` have sprung up after upstream MIR changes: rust-lang/rust#108944 - #10870 - #10577 - #10545 - #10517 r? `@flip1995`

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 9, 2023

This comment was marked as outdated.

Sign in to view

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 9, 2023

This comment was marked as outdated.

Sign in to view

This comment has been minimized.

Sign in to view

This comment was marked as outdated.

Sign in to view

rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Mar 9, 2023

cjgillot force-pushed the clear-local-info branch from 345a974 to e487459 Compare March 10, 2023 13:18

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 10, 2023

This comment was marked as outdated.

Sign in to view

This comment was marked as duplicate.

Sign in to view

This comment has been minimized.

Sign in to view

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 10, 2023

rustbot assigned lcnr Mar 10, 2023

cjgillot marked this pull request as ready for review March 10, 2023 18:12

rustbot assigned oli-obk and unassigned lcnr Mar 10, 2023

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 15, 2023

bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 16, 2023

bors merged commit 511364e into rust-lang:master Mar 16, 2023

rustbot added this to the 1.70.0 milestone Mar 16, 2023

This was referenced Mar 16, 2023

Perform unused assignment and unused variables lints on MIR. #101500

Open

Add a note about implicit temporaries on &mut (fn or const) #104857

Closed

Do NOT Review: CoAlloc: Allocator + Global API + Vec #108761

Closed

cjgillot deleted the clear-local-info branch March 18, 2023 10:07

rustbot added the perf-regression-triaged The performance regression has been triaged. label Mar 21, 2023

celinval mentioned this pull request Apr 26, 2023

Upgrade the toolchain to nightly-2023-04-16 model-checking/kani#2406

Merged

4 tasks

This was referenced May 17, 2023

False positive: redundant_clone rust-lang/rust-clippy#10577

Open

FP redundant_clone: Box rust-lang/rust-clippy#10517

Open

ryoqun added a commit to ryoqun/rust that referenced this pull request May 26, 2023

Revert "Auto merge of rust-lang#108944 - cjgillot:clear-local-info, r…

5edbb60

…=oli-obk" This reverts commit 511364e, reversing changes made to e386217.

ryoqun mentioned this pull request May 26, 2023

Dual (nightly+stable) clippy run is forced under ci due to its bug solana-labs/solana#31834

Closed

This was referenced Jun 2, 2023

[regression in 1.70] [clippy] redundant clone ; cloned value is neither consumed nor mutated rust-lang/rust-clippy#10870

Open

Move redundant_clone to nursery rust-lang/rust-clippy#10873

Merged

Jarcho mentioned this pull request Jul 28, 2023

Make borrow check results available to Clippy #108328

Closed

gurry mentioned this pull request Dec 21, 2023

arithmetic_overflow lint not triggered for overflowing shifts in promoteds #117949

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Wrap the whole LocalInfo in ClearCrossCrate. #108944

Wrap the whole LocalInfo in ClearCrossCrate. #108944

cjgillot commented Mar 9, 2023 •

edited

Loading

This comment was marked as outdated.

This comment has been minimized.

bors commented Mar 9, 2023

This comment was marked as outdated.

This comment has been minimized.

This comment was marked as outdated.

cjgillot commented Mar 10, 2023

This comment has been minimized.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as duplicate.

This comment has been minimized.

rust-timer commented Mar 10, 2023

cjgillot commented Mar 10, 2023

rustbot commented Mar 10, 2023

oli-obk commented Mar 10, 2023

bors commented Mar 15, 2023

bors commented Mar 16, 2023

bors commented Mar 16, 2023

rust-timer commented Mar 17, 2023

cjgillot commented Mar 18, 2023

nnethercote commented Mar 19, 2023

pnkfelix commented Mar 21, 2023

ryoqun commented May 26, 2023 •

edited

Loading

oli-obk commented May 26, 2023

Wrap the whole LocalInfo in ClearCrossCrate. #108944

Wrap the whole LocalInfo in ClearCrossCrate. #108944

Conversation

cjgillot commented Mar 9, 2023 • edited Loading

This comment was marked as outdated.

This comment has been minimized.

bors commented Mar 9, 2023

This comment was marked as outdated.

This comment has been minimized.

This comment was marked as outdated.

cjgillot commented Mar 10, 2023

This comment has been minimized.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as duplicate.

This comment has been minimized.

rust-timer commented Mar 10, 2023

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Instruction count

Max RSS (memory usage)

Cycles

cjgillot commented Mar 10, 2023

rustbot commented Mar 10, 2023

oli-obk commented Mar 10, 2023

bors commented Mar 15, 2023

bors commented Mar 16, 2023

bors commented Mar 16, 2023

rust-timer commented Mar 17, 2023

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Instruction count

Max RSS (memory usage)

Cycles

cjgillot commented Mar 18, 2023

nnethercote commented Mar 19, 2023

pnkfelix commented Mar 21, 2023

ryoqun commented May 26, 2023 • edited Loading

oli-obk commented May 26, 2023

cjgillot commented Mar 9, 2023 •

edited

Loading

ryoqun commented May 26, 2023 •

edited

Loading