Use libdir() instead of hard coded string. Fixes #10903 #10938
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
�Request for clarification, since I am not familiar with Windows: is it that on Windows they are also in the From skimming the patch it seems like it means the latter, not the former... |
|
Yes you're right, they are instead in the I was thinking about the binaries when writing the original comment: Binaries are in the |
bors
added a commit
that referenced
this pull request
Dec 14, 2013
rustpkg assumes library files to be in a directory called `lib`, but on Windows they are instead in the `bin` directory. This patch changes nothing on Unix system, since `libdir()` returns `"lib"` there.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jul 31, 2023
[`slow_vector_initialization`]: catch `Vec::new()` followed by `.resize(len, 0)` Closes rust-lang#10938 changelog: [`slow_vector_initialization`]: catch `Vec::new()` followed by `.resize(len, 0)`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rustpkg assumes library files to be in a directory called
lib, but on Windows they are instead in thebindirectory. This patch changes nothing on Unix system, sincelibdir()returns"lib"there.