Skip to content

bootstrap: Rename profile = user to profile = dist #112078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from

Conversation

Swarnlataaa
Copy link

@Swarnlataaa Swarnlataaa commented May 29, 2023

Fixes #112074

@rustbot
Copy link
Collaborator

rustbot commented May 29, 2023

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels May 29, 2023
@rust-log-analyzer
Copy link
Collaborator

The job x86_64-gnu-tools failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
   Compiling clap_complete v4.2.2
error: unexpected closing delimiter: `}`
    --> config.rs:1869:1
     |
953  |     fn parse_inner(args: &[String], get_toml: impl Fn(&Path) -> TomlConfig) -> Config {
     |                                                                                       - this delimiter might not be properly closed...
1096 |         }
1096 |         }
     |         - ...as it matches this but it has different indentation
1869 | }
     | ^ unexpected closing delimiter

error: could not compile `bootstrap` (lib) due to previous error
---
   Compiling bootstrap v0.0.0 (/checkout/src/bootstrap)
error: unexpected closing delimiter: `}`
    --> config.rs:1869:1
     |
953  |     fn parse_inner(args: &[String], get_toml: impl Fn(&Path) -> TomlConfig) -> Config {
     |                                                                                       - this delimiter might not be properly closed...
1096 |         }
1096 |         }
     |         - ...as it matches this but it has different indentation
1869 | }
     | ^ unexpected closing delimiter

error: could not compile `bootstrap` (lib) due to previous error
---
   Compiling bootstrap v0.0.0 (/checkout/src/bootstrap)
error: unexpected closing delimiter: `}`
    --> config.rs:1869:1
     |
953  |     fn parse_inner(args: &[String], get_toml: impl Fn(&Path) -> TomlConfig) -> Config {
     |                                                                                       - this delimiter might not be properly closed...
1096 |         }
1096 |         }
     |         - ...as it matches this but it has different indentation
1869 | }
     | ^ unexpected closing delimiter

error: could not compile `bootstrap` (lib) due to previous error
---
   Compiling bootstrap v0.0.0 (/checkout/src/bootstrap)
error: unexpected closing delimiter: `}`
    --> config.rs:1869:1
     |
953  |     fn parse_inner(args: &[String], get_toml: impl Fn(&Path) -> TomlConfig) -> Config {
     |                                                                                       - this delimiter might not be properly closed...
1096 |         }
1096 |         }
     |         - ...as it matches this but it has different indentation
1869 | }
     | ^ unexpected closing delimiter

error: could not compile `bootstrap` (lib) due to previous error
---
   Compiling bootstrap v0.0.0 (/checkout/src/bootstrap)
error: unexpected closing delimiter: `}`
    --> config.rs:1869:1
     |
953  |     fn parse_inner(args: &[String], get_toml: impl Fn(&Path) -> TomlConfig) -> Config {
     |                                                                                       - this delimiter might not be properly closed...
1096 |         }
1096 |         }
     |         - ...as it matches this but it has different indentation
1869 | }
     | ^ unexpected closing delimiter

error: could not compile `bootstrap` (lib) due to previous error

@jyn514 jyn514 changed the title Patch-1 bootstrap: Rename profile = user to profile = dist May 29, 2023
@clubby789 clubby789 added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 30, 2023
@bors
Copy link
Collaborator

bors commented Jun 27, 2023

☔ The latest upstream changes (presumably #113102) made this pull request unmergeable. Please resolve the merge conflicts.

@clubby789
Copy link
Contributor

Closing as #113068 has been merged

@clubby789 clubby789 closed this Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bootstrap: Rename profile = user to profile = dist
6 participants