Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[beta] Revert #113923 #119886

Merged
merged 2 commits into from
Jan 20, 2024
Merged

[beta] Revert #113923 #119886

merged 2 commits into from
Jan 20, 2024

Conversation

DianQK
Copy link
Member

@DianQK DianQK commented Jan 12, 2024

Per #t-compiler/meetings > [weekly] 2024-01-11 discussion, revert #113923. Also revert associated #118568.

The PR #113923 causes the regression issue #118609. We need more time to find a proper solution.

Discussions start at 412365838 and continue to 412369643.

Fixes #118609.

Same as #119885 but backported to beta.

r? compiler

…r=pnkfelix"

This reverts commit 503e129, reversing
changes made to 0e7f91b.
…to, r=pnkfelix"

This reverts commit 8c2b577, reversing
changes made to 9cf18e9.
@rustbot
Copy link
Collaborator

rustbot commented Jan 12, 2024

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 12, 2024
@rustbot
Copy link
Collaborator

rustbot commented Jan 12, 2024

The Miri subtree was changed

cc @rust-lang/miri

@DianQK
Copy link
Member Author

DianQK commented Jan 12, 2024

@rustbot label +beta-nominated +beta-accepted

@rustbot
Copy link
Collaborator

rustbot commented Jan 12, 2024

Error: Label beta-accepted can only be set by Rust team members

Please file an issue on GitHub at triagebot if there's a problem with this bot, or reach out on #t-infra on Zulip.

@DianQK
Copy link
Member Author

DianQK commented Jan 12, 2024

@rustbot label +beta-nominated

@rustbot rustbot added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jan 12, 2024
@apiraino
Copy link
Contributor

Beta backport accepted as per compiler team on Zulip

@rustbot label +beta-accepted

@rustbot rustbot added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Jan 18, 2024
@weihanglo
Copy link
Member

I've created another beta backport PR #120111. Feel free to roll them up :)

@cuviper
Copy link
Member

cuviper commented Jan 19, 2024

Procedural note: we normally deal with backport flags on the master PR, especially because it doesn't show up in the release team's queries until merged. That's kind of a chicken-and-egg situation when you're already targeting beta. Then we may ask for help backporting if there's some conflict, but generally we can handle it. :)

https://forge.rust-lang.org/release/backporting.html

Anyway, no worries, I've verified that this is a clean match of #119885.

@bors r+ rollup=never

@bors
Copy link
Contributor

bors commented Jan 19, 2024

📌 Commit 251322e has been approved by cuviper

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 19, 2024
@cuviper cuviper removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jan 19, 2024
@DianQK
Copy link
Member Author

DianQK commented Jan 19, 2024

Procedural note: we normally deal with backport flags on the master PR, especially because it doesn't show up in the release team's queries until merged. That's kind of a chicken-and-egg situation when you're already targeting beta. Then we may ask for help backporting if there's some conflict, but generally we can handle it. :)

https://forge.rust-lang.org/release/backporting.html

Anyway, no worries, I've verified that this is a clean match of #119885.

@bors r+ rollup=never

Thanks, I got it. I just need to add the beta-nominated to the PR of the target master branch.
(Based on the discussion at the meeting I assumed this was already in beta-accepted, so I submitted the PR.)

@bors
Copy link
Contributor

bors commented Jan 20, 2024

⌛ Testing commit 251322e with merge a2411cb...

@bors
Copy link
Contributor

bors commented Jan 20, 2024

☀️ Test successful - checks-actions
Approved by: cuviper
Pushing a2411cb to beta...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 20, 2024
@bors bors merged commit a2411cb into rust-lang:beta Jan 20, 2024
12 checks passed
@rustbot rustbot added this to the 1.76.0 milestone Jan 20, 2024
@DianQK DianQK deleted the beta-revert-pr-113923 branch January 20, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants