Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: enble LLVM download for windows-gnu hosts #133266

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mati865
Copy link
Contributor

@mati865 mati865 commented Nov 20, 2024

Continuation of #132781

try-job: dist-i686-mingw
try-job: dist-x86_64-mingw

@rustbot
Copy link
Collaborator

rustbot commented Nov 20, 2024

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Nov 20, 2024
@mati865
Copy link
Contributor Author

mati865 commented Nov 20, 2024

Basically my plan is to do try build with dist so the artifacts get uploaded and then do another try but with test jobs.
If that fails, I think we should merge dist builders change only and then in later PR do the same for test jobs.

@Kobzol
Copy link
Contributor

Kobzol commented Nov 20, 2024

I would personally prefer to disable LLVM download on the dist runners, to exercise the LLVM build path regularly.

@mati865
Copy link
Contributor Author

mati865 commented Nov 20, 2024

I think dist runners always build LLVM artifacts for download (at least that appears to be the case in #132781) despite using the same environment variable.
Even if that's not the case, changing it would be a bigger change that affects all platforms.

@Kobzol
Copy link
Contributor

Kobzol commented Nov 21, 2024

Yeah, just to clarify, what I meant was that we shouldn't change the behavior on dist runners - they should always build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants