Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add #[repr(u128)]/#[repr(i128)] enums to improper_ctypes_definitions #138282

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add #[repr(u128)]/#[repr(i128)] enums to improper_ctypes_definitions #138282

wants to merge 1 commit into from
+86 −32

Conversation

beetrees
Copy link
Contributor

@beetrees beetrees commented Mar 9, 2025 •
edited
Loading

This makes them warn whenever a plain u128/i128 would. If the lang team decides to merge #137306 then this can be reverted.

Tracking issue: #56071

@rustbot
Copy link
Collaborator

rustbot commented Mar 9, 2025

r? @cjgillot

rustbot has assigned @cjgillot.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 9, 2025
@beetrees beetrees mentioned this pull request Mar 9, 2025
Open
@oli-obk
Copy link
Contributor

oli-obk commented Mar 18, 2025

r? @oli-obk

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Mar 18, 2025

📌 Commit 68dce3d has been approved by oli-obk

It is now in the queue for this repository.

@rustbot rustbot assigned oli-obk and unassigned cjgillot Mar 18, 2025
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 18, 2025
@bors
Copy link
Collaborator

bors commented Mar 20, 2025

☔ The latest upstream changes (presumably #138714) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 20, 2025
@beetrees beetrees force-pushed the repr128-not-ffi-safe branch from 68dce3d to eda9973 Compare March 20, 2025 02:03
@beetrees
Copy link
Contributor Author

Rebased to fix merge conflict.

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oli-obk oli-obk

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@beetrees @rustbot @oli-obk @bors @cjgillot