Skip to content

Enable reproducible-build-2 for Windows MSVC #142843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 24, 2025
Merged

Enable reproducible-build-2 for Windows MSVC #142843

merged 1 commit into from
Jun 24, 2025

Conversation

dpaoliello
Copy link
Contributor

Works with MSVC if instructing the linker to avoid timestamps and deleting the PDB between compilations.

Addresses item in #128602

try-job: x86_64-mingw-*
try-job: x86_64-msvc-*
try-job: i686-msvc-*

@rustbot
Copy link
Collaborator

rustbot commented Jun 21, 2025

jieyouxu is not on the review rotation at the moment.
They may take a while to respond.

@rustbot
Copy link
Collaborator

rustbot commented Jun 21, 2025

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 21, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jun 21, 2025

The run-make-support library was changed

cc @jieyouxu

This PR modifies run-make tests.

cc @jieyouxu

@Noratrieb
Copy link
Member

@bors2 try

@rust-bors
Copy link

rust-bors bot commented Jun 21, 2025

⌛ Trying commit e3bd3be with merge c6ea3a5…

To cancel the try build, run the command @bors2 try cancel.

rust-bors bot added a commit that referenced this pull request Jun 21, 2025
@rust-bors
Auto merge of #142843 - dpaoliello:reproducible-build-2, r=<try>
c6ea3a5 
Enable reproducible-build-2 for Windows

Works with MSVC if instructing the linker to avoid timestamps and deleting the PDB between compilations.

Addresses item in #128602

---

try-job: x86_64-mingw-*
try-job: x86_64-msvc-*
try-job: i686-msvc-*
jieyouxu
jieyouxu reviewed Jun 21, 2025
View reviewed changes
@rust-bors
Copy link

rust-bors bot commented Jun 22, 2025

💔 Test failed

@jieyouxu
Copy link
Member

@bors2 delegate=try

@rust-bors
Copy link

rust-bors bot commented Jun 22, 2025

@dpaoliello can now perform try builds on this pull request

@jieyouxu
Copy link
Member 

2025-06-22T00:32:58.1551644Z ---- [run-make] tests\run-make\reproducible-build-2 stdout ----
2025-06-22T00:32:58.1552110Z 
2025-06-22T00:32:58.1555060Z error: rmake recipe failed to complete
2025-06-22T00:32:58.1555724Z status: exit code: 101
2025-06-22T00:32:58.1556440Z command: "D:\\a\\rust\\rust\\build\\x86_64-pc-windows-gnu\\test\\run-make\\reproducible-build-2\\rmake.exe"
2025-06-22T00:32:58.1557299Z stdout: none
2025-06-22T00:32:58.1557688Z --- stderr -------------------------------
2025-06-22T00:32:58.1558035Z 
2025-06-22T00:32:58.1558466Z thread 'main' panicked at D:\a\rust\rust\tests\run-make\reproducible-build-2\rmake.rs:29:5:
2025-06-22T00:32:58.1559969Z the file "reproducible-build" could not be moved over to "reproducible-build-a": Os { code: 2, kind: NotFound, message: "The system cannot find the file specified." }
2025-06-22T00:32:58.1561219Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
2025-06-22T00:32:58.1561868Z ------------------------------------------

@rustbot author

@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 23, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jun 23, 2025

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@rustbot rustbot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jun 23, 2025
@dpaoliello dpaoliello force-pushed the reproducible-build-2 branch from e3bd3be to 29e5de1 Compare June 23, 2025 18:53
@dpaoliello
Copy link
Contributor Author

@bors2 try

@rust-bors
Copy link

rust-bors bot commented Jun 23, 2025

⌛ Trying commit 29e5de1 with merge 22c5b72…

To cancel the try build, run the command @bors2 try cancel.

rust-bors bot added a commit that referenced this pull request Jun 23, 2025
@rust-bors
Auto merge of #142843 - dpaoliello:reproducible-build-2, r=<try>
22c5b72 
Enable reproducible-build-2 for Windows

Works with MSVC if instructing the linker to avoid timestamps and deleting the PDB between compilations.

Addresses item in #128602

---

try-job: x86_64-mingw-*
try-job: x86_64-msvc-*
try-job: i686-msvc-*
@rust-bors
Copy link

rust-bors bot commented Jun 23, 2025

💔 Test failed

@dpaoliello dpaoliello force-pushed the reproducible-build-2 branch from 29e5de1 to 81a7cb6 Compare June 23, 2025 21:34
@dpaoliello
Copy link
Contributor Author

@bors2 try

rust-bors bot added a commit that referenced this pull request Jun 23, 2025
@rust-bors
Auto merge of #142843 - dpaoliello:reproducible-build-2, r=<try>
a1a7b8b 
Enable reproducible-build-2 for Windows

Works with MSVC if instructing the linker to avoid timestamps and deleting the PDB between compilations.

Addresses item in #128602

---

try-job: x86_64-mingw-*
try-job: x86_64-msvc-*
try-job: i686-msvc-*
@rust-bors
Copy link

rust-bors bot commented Jun 23, 2025

⌛ Trying commit 81a7cb6 with merge a1a7b8b…

To cancel the try build, run the command @bors2 try cancel.

@rust-bors
Copy link

rust-bors bot commented Jun 24, 2025

☀️ Try build successful (CI)
Build commit: a1a7b8b (a1a7b8b12cb36844e59121d4459ebe02ee9f95cc, parent: 706f244db581212cabf2e619e0113d70999b2bbe)

@dpaoliello dpaoliello changed the title Enable reproducible-build-2 for Windows Enable reproducible-build-2 for Windows MSVC Jun 24, 2025
@dpaoliello
Copy link
Contributor Author

Disabled GNU since the linker seems to be non-deterministic.

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 24, 2025
jieyouxu
jieyouxu approved these changes Jun 24, 2025
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jieyouxu
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Jun 24, 2025

📌 Commit 81a7cb6 has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 24, 2025
@GuillaumeGomez GuillaumeGomez mentioned this pull request Jun 24, 2025
Merged
bors added a commit that referenced this pull request Jun 24, 2025
@bors
Auto merge of #142962 - GuillaumeGomez:rollup-do1coji, r=GuillaumeGomez
3129d37 
Rollup of 7 pull requests

Successful merges:

 - #137268 (Allow comparisons between `CStr`, `CString`, and `Cow<CStr>`.)
 - #142704 (Remove the deprecated unstable `concat_idents!` macro)
 - #142742 ([win][aarch64] Fix linking statics on Arm64EC, take 2)
 - #142843 (Enable reproducible-build-2 for Windows MSVC)
 - #142916 (rustdoc-json: Add test for `#[optimize(..)]`)
 - #142919 (rustdoc-json: Add test for `#[cold]`)
 - #142944 (Stats output tweaks)

Failed merges:

 - #142825 (Port `#[track_caller]` to the new attribute system)

r? `@ghost`
`@rustbot` modify labels: rollup
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Jun 24, 2025
@workingjubilee
Rollup merge of rust-lang#142843 - dpaoliello:reproducible-build-2, r…
cce6177 
…=jieyouxu

Enable reproducible-build-2 for Windows MSVC

Works with MSVC if instructing the linker to avoid timestamps and deleting the PDB between compilations.

Addresses item in rust-lang#128602

---

try-job: x86_64-mingw-*
try-job: x86_64-msvc-*
try-job: i686-msvc-*
@workingjubilee workingjubilee mentioned this pull request Jun 24, 2025
Closed
@bors bors merged commit d9ee943 into rust-lang:master Jun 24, 2025
10 checks passed
@rustbot rustbot added this to the 1.90.0 milestone Jun 24, 2025
rust-timer added a commit that referenced this pull request Jun 24, 2025
@rust-timer
Unrolled build for #142843
8c9c430 
Rollup merge of #142843 - dpaoliello:reproducible-build-2, r=jieyouxu

Enable reproducible-build-2 for Windows MSVC

Works with MSVC if instructing the linker to avoid timestamps and deleting the PDB between compilations.

Addresses item in #128602

---

try-job: x86_64-mingw-*
try-job: x86_64-msvc-*
try-job: i686-msvc-*
@dpaoliello dpaoliello deleted the reproducible-build-2 branch June 24, 2025 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jieyouxu jieyouxu jieyouxu approved these changes

Assignees

@jieyouxu jieyouxu

Labels
A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.90.0
Development

Successfully merging this pull request may close these issues.
5 participants
@dpaoliello @rustbot @Noratrieb @jieyouxu @bors