Make syntax::owned_slice a Box<[T]> wrapper. #19326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it correct (e.g. avoiding null pointers) and safe.
| @@ -85,6 +85,7 @@ | |||
| #[doc(no_inline)] pub use slice::{SlicePrelude, AsSlice, CloneSlicePrelude}; | |||
| #[doc(no_inline)] pub use slice::{VectorVector, PartialEqSlicePrelude, OrdSlicePrelude}; | |||
| #[doc(no_inline)] pub use slice::{CloneSliceAllocPrelude, OrdSliceAllocPrelude, SliceAllocPrelude}; | |||
| #[doc(no_inline)] pub use slice::{BoxedSlicePrelude}; | |||
There was a problem hiding this comment.
Why do we need this in the prelude?
There was a problem hiding this comment.
I assumed that the Prelude name meant it was just an oversight that it wasn't added to the prelude.
|
Can it be just a type alias? Or even replace occurrences of it with |
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Nov 27, 2014
This makes it correct (e.g. avoiding null pointers) and safe.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it correct (e.g. avoiding null pointers) and safe.