[r+] Add note about libc::exit's unsafety. #21026
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
| /// | ||
| /// fn main() { | ||
| /// unsafe { | ||
| /// libc::exit(1 as libc::c_int); |
|
@sfackler addressed |
|
|
||
| /// Exits the running program in a possibly dangerous manner. | ||
| /// | ||
| /// # Unsafety |
There was a problem hiding this comment.
One last minor nit/question: Should this heading be Warning or something like that rather than Unsafety? I'm not sure how strict we want to be about the use of the term "unsafe" in documentation.
There was a problem hiding this comment.
Given that the function is an unsafe fn, I chose unsafety rather than something like "Warning".
bors
added a commit
that referenced
this pull request
Jan 14, 2015
Add note about libc::exit's unsafety. Reviewed-by: sfackler
bors
referenced
this pull request
Jan 14, 2015
nikomatsakis
changed the title
bors
added a commit
that referenced
this pull request
Jan 17, 2015
[r+] Add note about libc::exit's unsafety. Reviewed-by: steveklabnik
bors
referenced
this pull request
Jan 17, 2015
bors
added a commit
that referenced
this pull request
Jan 17, 2015
[r+] Add note about libc::exit's unsafety. Reviewed-by: steveklabnik
bors
referenced
this pull request
Jan 17, 2015
|
Doing this manually as part of #21300 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19245.