Modify the ExprUseVisitor to walk each part of an AutoRef #24191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reassigning to @pnkfelix - I really don't know ExprUseVisitor as well as I should, sorry. |
nikomatsakis
force-pushed
the
issue-20791
branch
from
3a5cf5c to
7458503
Compare
|
|
||
| fn main() { | ||
| let x: &i32; | ||
| let y = x as *const Foo; //~ ERROR use of possibly uninitialized variable: `*x` |
There was a problem hiding this comment.
This file should not be in test/run-pass
|
@nikomatsakis r=me when above issues are addressed. |
particular to treat an AutoUnsize as as kind of "instantaneous" borrow of the value being unsized. This prevents us from feeding uninitialized data. This caused a problem for the eager reborrow of comparison traits, because that wound up introducing a "double AutoRef", which was not being thoroughly checked before but turned out not to type check. Fortunately, we can just remove that "eager reborrow" as it is no longer needed now that `PartialEq` doesn't force both LHS and RHS to have the same type (and even if we did have this problem, the better way would be to lean on introducing a common supertype).
nikomatsakis
force-pushed
the
issue-20791
branch
from
7458503 to
1e79870
Compare
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Apr 9, 2015
Modify the ExprUseVisitor to walk each part of an AutoRef, and in particular to treat an AutoUnsize as as kind of \"instantaneous\" borrow of the value being unsized. This prevents us from feeding uninitialized data. This caused a problem for the eager reborrow of comparison traits, because that wound up introducing a \"double AutoRef\", which was not being thoroughly checked before but turned out not to type check. Fortunately, we can just remove that \"eager reborrow\" as it is no longer needed now that `PartialEq` doesn't force both LHS and RHS to have the same type (and even if we did have this problem, the better way would be to lean on introducing a common supertype). Fixes rust-lang#20791. r? @nrc
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Apr 9, 2015
Modify the ExprUseVisitor to walk each part of an AutoRef, and in particular to treat an AutoUnsize as as kind of \"instantaneous\" borrow of the value being unsized. This prevents us from feeding uninitialized data. This caused a problem for the eager reborrow of comparison traits, because that wound up introducing a \"double AutoRef\", which was not being thoroughly checked before but turned out not to type check. Fortunately, we can just remove that \"eager reborrow\" as it is no longer needed now that `PartialEq` doesn't force both LHS and RHS to have the same type (and even if we did have this problem, the better way would be to lean on introducing a common supertype). Fixes rust-lang#20791. r? @nrc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify the ExprUseVisitor to walk each part of an AutoRef, and in
particular to treat an AutoUnsize as as kind of "instantaneous" borrow
of the value being unsized. This prevents us from feeding uninitialized
data.
This caused a problem for the eager reborrow of comparison traits,
because that wound up introducing a "double AutoRef", which was not
being thoroughly checked before but turned out not to type check.
Fortunately, we can just remove that "eager reborrow" as it is no longer
needed now that
PartialEqdoesn't force both LHS and RHS to have thesame type (and even if we did have this problem, the better way would be
to lean on introducing a common supertype).
Fixes #20791.
r? @nrc