Bump minimum OS X to build with Xcode 8 toolchain #36656
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This fix… uh… has potential for unintended side effects. |
|
@nagisa totally agreed. I'm not really a fan, but currently building LLVM requires this (or something like it) on macOS |
|
Yes we unfortunately can't blanket do this as the bots require this to build compatible binaries for OSX. (those that run on 10.7). We'll need to figure out a more nuanced solution here most likely. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps the minimum OS X version, which allows us to satisfy the new minimum requirements for using the Xcode 8 build chain.
Some info here: https://forums.developer.apple.com/thread/63266
Partial fix for: #36650
r? @brson