-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up E0689 explanation #73472
Clean up E0689 explanation #73472
Conversation
This error indicates that the numeric value for the method being passed exists | ||
but the type of the numeric value or binding could not be identified. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe maybe it would be better to arrange above the example like the below description which this
refers to. Or maybe it would be better if we use This error
rather than The error
for the text below to avoid confusion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the feedback. Most of the error messages are of th esimilar fashion and I think it is fine for now.
@bors r+ rollup |
📌 Commit 1d08b1b has been approved by |
…an-DPC Clean up E0689 explanation r? @Dylan-DPC
…an-DPC Clean up E0689 explanation r? @Dylan-DPC
…an-DPC Clean up E0689 explanation r? @Dylan-DPC
…an-DPC Clean up E0689 explanation r? @Dylan-DPC
…arth Rollup of 9 pull requests Successful merges: - rust-lang#72271 (Improve compiler error message for wrong generic parameter order) - rust-lang#72493 ( move leak-check to during coherence, candidate eval) - rust-lang#73398 (A way forward for pointer equality in const eval) - rust-lang#73472 (Clean up E0689 explanation) - rust-lang#73496 (Account for multiple impl/dyn Trait in return type when suggesting `'_`) - rust-lang#73515 (Add second message for LiveDrop errors) - rust-lang#73567 (Clarify --extern documentation.) - rust-lang#73572 (Fix typos in doc comments) - rust-lang#73590 (bootstrap: no `config.toml` exists regression) Failed merges: r? @ghost
☔ The latest upstream changes (presumably #73643) made this pull request unmergeable. Please resolve the merge conflicts. |
r? @Dylan-DPC