Skip to content

Commit 3b4bdfc

Browse files
chenyukangJohnTitor
andcommitted
fix words on r=someone
Co-authored-by: Yuki Okushi <jtitor@2k36.org>
1 parent 527e0ad commit 3b4bdfc

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

src/walkthrough.md

+3-2
Original file line numberDiff line numberDiff line change
@@ -196,8 +196,9 @@ Feel free to ask questions or discuss things you don't understand or disagree wi
196196
recognize that the PR won't be merged unless someone on the Rust team approves
197197
it. If a reviewer leave a comment like `r=me after fixing ...`, that means they approve the PR and
198198
you can merge it with comment with `@bors r=reviwer-github-id`(e.g. `@bors r=eddyb`) to merge it
199-
after fixing lefted trivial issues. `r=someone` requires permission and the reviwer use
200-
delegate command gives it to you in this way.
199+
after fixing trivial issues. Note that `r=someone` requires permission and bors could say
200+
something like "🔑 Insufficient privileges..." when commenting `r=someone`. In that case,
201+
you have to ask the reviewer to revisit your PR.
201202

202203
When your reviewer approves the PR, it will go into a queue for yet another bot
203204
called `@bors`. `@bors` manages the CI build/merge queue. When your PR reaches

0 commit comments

Comments
 (0)