Skip to content

Commit 0b72313

Browse files
committed
Switch self profile to use HW counters instead of walltime
1 parent f8cc0b2 commit 0b72313

File tree

3 files changed

+9
-9
lines changed

3 files changed

+9
-9
lines changed

collector/src/bin/rustc-fake.rs

+2-1
Original file line numberDiff line numberDiff line change
@@ -95,8 +95,9 @@ fn main() {
9595
if wrapper == "PerfStatSelfProfile" {
9696
cmd.arg(&format!(
9797
"-Zself-profile={}",
98-
prof_out_dir.to_str().unwrap()
98+
prof_out_dir.to_str().unwrap(),
9999
));
100+
cmd.arg("-Zself-profile-counter=instructions:u");
100101
let _ = fs::remove_dir_all(&prof_out_dir);
101102
let _ = fs::create_dir_all(&prof_out_dir);
102103
}

site/frontend/templates/pages/detailed-query.html

+6-7
Original file line numberDiff line numberDiff line change
@@ -79,20 +79,19 @@ <h4>Artifact Size</h4>
7979
<tbody id="artifact-body">
8080
</tbody>
8181
</table>
82-
<p>'Time (%)' is the percentage of the cpu-clock time spent on this query (we do not use
83-
wall-time as we want to account for parallelism).</p>
82+
<p>'Instructions (%)' is the percentage of instructions executed on this query.</p>
8483
<p>Executions do not include cached executions.</p>
8584
<table>
8685
<thead>
8786
<tr id="table-header">
8887
<th data-sort-idx="1" data-default-sort-dir="1">Query/Function</th>
89-
<th data-sort-idx="10" data-default-sort-dir="-1">Time (%)</th>
90-
<th data-sort-idx="2" data-default-sort-dir="-1">Time (s)</th>
91-
<th data-sort-idx="11" data-default-sort-dir="-1" class="delta">Time delta</th>
88+
<th data-sort-idx="10" data-default-sort-dir="-1">Instructions (%)</th>
89+
<th data-sort-idx="2" data-default-sort-dir="-1">Instructions</th>
90+
<th data-sort-idx="11" data-default-sort-dir="-1" class="delta">Instructions delta</th>
9291
<th data-sort-idx="5" data-default-sort-dir="-1">Executions</th>
9392
<th data-sort-idx="12" data-default-sort-dir="-1" class="delta">Executions delta</th>
94-
<th class="incr" data-sort-idx="7" data-default-sort-dir="-1" title="Incremental loading time">
95-
Incremental loading (s)</th>
93+
<th class="incr" data-sort-idx="7" data-default-sort-dir="-1" title="Incremental loading instructions">
94+
Incremental loading instructions</th>
9695
<th class="incr delta" data-sort-idx="13" data-default-sort-dir="-1">Incremental loading delta</th>
9796
</tr>
9897
</thead>

site/src/request_handlers/self_profile.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -587,7 +587,7 @@ pub async fn handle_self_profile(
587587
.benchmark(selector::Selector::One(bench_name.to_string()))
588588
.profile(selector::Selector::One(profile.parse().unwrap()))
589589
.scenario(selector::Selector::One(scenario))
590-
.metric(selector::Selector::One(Metric::CpuClock));
590+
.metric(selector::Selector::One(Metric::InstructionsUser));
591591

592592
// Helper for finding an `ArtifactId` based on a commit sha
593593
let find_aid = |commit: &str| {

0 commit comments

Comments
 (0)