Skip to content

Display/note error messages when builds fail in the collector #1062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Mark-Simulacrum opened this issue Oct 6, 2021 · 0 comments · Fixed by #1128
Closed

Display/note error messages when builds fail in the collector #1062

Mark-Simulacrum opened this issue Oct 6, 2021 · 0 comments · Fixed by #1128
Labels
A-ui Issues dealing with the perf.rlo site UI C-feature-request A feature request

Comments

@Mark-Simulacrum
Copy link
Member

Currently we just don't have any pstat values for builds that failed in the collector, like for https://perf.rust-lang.org/compare.html?start=98a5a98f44130b5bafb4f2b2f3126fb22a5a3228&end=9dcfdc218c68c3bb7a32f219622672a50996a459. That looks pretty confusing to users, so we should try to avoid this kind of UI.

We can likely check the error table for the base & next commits unconditionally on all the series we're querying and put links or something in to the error message when running that benchmark. Surfacing this at the top of the page for any benchmarks which stopped compiling is likely particularly critical on e.g. try builds, since otherwise that information seems likely to be pretty hidden (and we'd end up landing breakage onto master).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ui Issues dealing with the perf.rlo site UI C-feature-request A feature request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant