-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
query verification is a little non-deterministic #1105
Comments
This seems preferable so we don't miss regressions in the cost of the verification itself. |
This was referenced Nov 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I suspect in part due to Spans having a hash dependent on the commit hash (since we remap paths to include the commit hash), we are seeing increased noise in benchmarks (particularly incr-unchanged) that is not yet being ignored by the statistical significance algorithm as it was fairly recently introduced.
I suspect we'll want to do one of these:
The text was updated successfully, but these errors were encountered: