Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If bootstrap timing partially or completely missing, indication on compare page is easy to miss #1297

Closed
klensy opened this issue Apr 19, 2022 · 5 comments
Labels
A-ui Issues dealing with the perf.rlo site UI

Comments

@klensy
Copy link
Contributor

klensy commented Apr 19, 2022

See the links on rust-lang/rust#96188

@lqd
Copy link
Member

lqd commented Apr 19, 2022

The compare page shows that when a benchmark stops building: e.g. in this case the summary bot mentioned the rustc benchmark stopped building and it's showing that at the top of the compare page for that run.

In the other cases, if a given run doesn't itself break a benchmark, then they are listed in the status page.

Maybe we should automatically open rust-lang/rust issues when that happens, much like toolstate status changes.

@rylev
Copy link
Member

rylev commented Apr 25, 2022

So I guess the issue here is not that the there's no indication (there is - see below), but that the indication isn't very clear.

image

@rylev rylev changed the title If bootstrap timing partially or completely missing, no indication of that on compare page If bootstrap timing partially or completely missing, indication on compare page is easy to miss Apr 25, 2022
@rylev rylev added the A-ui Issues dealing with the perf.rlo site UI label Apr 25, 2022
@klensy
Copy link
Contributor Author

klensy commented Apr 25, 2022

No, about empty bootstrap timings table: for first link https://perf.rust-lang.org/compare.html?start=8305398d7ae6128811ec2b3223939bcd067530c2&end=311e2683e1bad87715b1558f7900e294d24ce491

chrome_2022-04-25_10-52-07

Or partially empty one for second one (missing second column), without clear indication, that something wrong happened in data.

But that newly broken not too good too.

@Kobzol
Copy link
Contributor

Kobzol commented Jul 1, 2023

image
This is how it currently looks like. I think that it's much clearer that there is a problem with bootstrap now. @klensy if you agree, feel free to close this issue.

@klensy
Copy link
Contributor Author

klensy commented Jul 1, 2023

Ok.

@klensy klensy closed this as completed Jul 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ui Issues dealing with the perf.rlo site UI
Projects
None yet
Development

No branches or pull requests

4 participants