Skip to content

License the whole rustc-perf repository under the MIT license #1933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
30 of 31 tasks
Kobzol opened this issue Jun 28, 2024 · 32 comments
Closed
30 of 31 tasks

License the whole rustc-perf repository under the MIT license #1933

Kobzol opened this issue Jun 28, 2024 · 32 comments

Comments

@Kobzol
Copy link
Contributor

Kobzol commented Jun 28, 2024

This repository currently does not have a top-level LICENSE file (#1880), which means that not all of its code is covered by a license.
We would like to license the whole rustc-perf repository (apart from the collector/compile-benchmarks directory, which has its own licenses) under the MIT License, to make it easier to use rustc-perf in rustc source distributions. In the future, we might want to extend this license to MIT/Apache 2.0 (although currently we're aiming at MIT, as a start, since it is easier), hence we would like to ask the contributors to agree with a dual MIT/Apache 2.0 license, as a sort of future-proofing.

To do that, we need contributors that made commits to this repository (with some caveats, see below) to agree by posting a comment stating their approval to this issue. Please see instructions at the bottom of this issue if you are mentioned in the list below. I will try to also contact the contributors individually.

How did we select the list of contributors from whom we need the approval?

I analyzed the commits from rustc-perf going all the way back to e99853d4777a1df001853c619eead0c891c28488. In this commit, there was a top-level MIT license at the root of the repository, therefore all earlier commits should be MIT licensed. Then I found a set of contributors that made at least a single commit to any other directory than collector and site, because these two were already MIT licensed.

I used this script for performing the analysis.

Related issues: #1880, #1927
PR with the new license: #1881

Checkoff

To agree to the licensing terms, please comment with the following text on this issue (you can copy the text using the copy button on the right):

I license past and future contributions to the `rust-lang/rustc-perf` repository under the dual MIT/Apache-2.0 license, allowing licensees to chose either at their option.

Thank you very much!

Affected contributors:

@Kobzol
Copy link
Contributor Author

Kobzol commented Jun 28, 2024

I license past and future contributions to the rust-lang/rustc-perf repository under the dual MIT/Apache-2.0 license, allowing licensees to chose either at their option.

@GuillaumeGomez
Copy link
Member

I license past and future contributions to the rust-lang/rustc-perf repository under the dual MIT/Apache-2.0 license, allowing licensees to chose either at their option.

7 similar comments
@ishitatsuyuki
Copy link
Contributor

I license past and future contributions to the rust-lang/rustc-perf repository under the dual MIT/Apache-2.0 license, allowing licensees to chose either at their option.

@homersimpsons
Copy link
Contributor

I license past and future contributions to the rust-lang/rustc-perf repository under the dual MIT/Apache-2.0 license, allowing licensees to chose either at their option.

@s7tya
Copy link
Contributor

s7tya commented Jun 28, 2024

I license past and future contributions to the rust-lang/rustc-perf repository under the dual MIT/Apache-2.0 license, allowing licensees to chose either at their option.

@blyxyas
Copy link
Member

blyxyas commented Jun 28, 2024

I license past and future contributions to the rust-lang/rustc-perf repository under the dual MIT/Apache-2.0 license, allowing licensees to chose either at their option.

@sn99
Copy link
Contributor

sn99 commented Jun 28, 2024

I license past and future contributions to the rust-lang/rustc-perf repository under the dual MIT/Apache-2.0 license, allowing licensees to chose either at their option.

@kennytm
Copy link
Member

kennytm commented Jun 28, 2024

I license past and future contributions to the rust-lang/rustc-perf repository under the dual MIT/Apache-2.0 license, allowing licensees to chose either at their option.

@weihanglo
Copy link
Member

I license past and future contributions to the rust-lang/rustc-perf repository under the dual MIT/Apache-2.0 license, allowing licensees to chose either at their option.

@RalfJung
Copy link
Member

I license all my past contributions to the rust-lang/rustc-perf repository under the dual MIT/Apache-2.0 license, allowing licensees to chose either at their option.

(I don't think it makes sense for me to make statements about future contributions now, and I don't see how that is relevant for this licensing issue.)

@rylev
Copy link
Member

rylev commented Jun 28, 2024

I license past and future contributions to the rust-lang/rustc-perf repository under the dual MIT/Apache-2.0 license, allowing licensees to chose either at their option.

2 similar comments
@alexcrichton
Copy link
Member

I license past and future contributions to the rust-lang/rustc-perf repository under the dual MIT/Apache-2.0 license, allowing licensees to chose either at their option.

@alex
Copy link
Member

alex commented Jun 28, 2024

I license past and future contributions to the rust-lang/rustc-perf repository under the dual MIT/Apache-2.0 license, allowing licensees to chose either at their option.

@eth3lbert
Copy link
Contributor

I license past and future contributions to the rust-lang/rustc-perf repository under the dual MIT/Apache-2.0 license, allowing licensees to chose either at their option.

1 similar comment
@pnkfelix
Copy link
Member

I license past and future contributions to the rust-lang/rustc-perf repository under the dual MIT/Apache-2.0 license, allowing licensees to chose either at their option.

@SimonSapin
Copy link
Contributor

I license past and future contributions to the rust-lang/rustc-perf repository under the dual MIT/Apache-2.0 license, allowing licensees to chose either at their option.

3 similar comments
@wesleywiser
Copy link
Member

I license past and future contributions to the rust-lang/rustc-perf repository under the dual MIT/Apache-2.0 license, allowing licensees to chose either at their option.

@klensy
Copy link
Contributor

klensy commented Jun 28, 2024

I license past and future contributions to the rust-lang/rustc-perf repository under the dual MIT/Apache-2.0 license, allowing licensees to chose either at their option.

@jsha
Copy link
Contributor

jsha commented Jun 28, 2024

I license past and future contributions to the rust-lang/rustc-perf repository under the dual MIT/Apache-2.0 license, allowing licensees to chose either at their option.

@nnethercote
Copy link
Contributor

I license past and future contributions to the rust-lang/rustc-perf repository under the dual MIT/Apache-2.0 license, allowing licensees to chose either at their option.

@chengr4
Copy link
Contributor

chengr4 commented Jun 29, 2024

I license past and future contributions to the rust-lang/rustc-perf repository under the dual MIT/Apache-2.0 license, allowing licensees to chose either at their option.

@jyn514
Copy link
Member

jyn514 commented Jun 29, 2024

... good luck.


I license all my past contributions to the rust-lang/rustc-perf repository under the dual MIT/Apache-2.0 license, allowing licensees to chose either at their option.

@est31
Copy link
Member

est31 commented Jun 29, 2024

I license all my past contributions to the rust-lang/rustc-perf repository under the dual MIT/Apache-2.0 license, allowing licensees to chose either at their option.

@Mark-Simulacrum
Copy link
Member

I license past and future contributions to the rust-lang/rustc-perf repository under the dual MIT/Apache-2.0 license, allowing licensees to chose either at their option.

@apiraino
Copy link
Contributor

I think I don't need to make any licensing explicit on my end since my only contribution was a typo fix in a perf. triage report 😄 but anyways

I license past and future contributions to the rust-lang/rustc-perf repository under the dual MIT/Apache-2.0 license, allowing licensees to chose either at their option.

@pietroalbini
Copy link
Member

I license past and future contributions to the rust-lang/rustc-perf repository under the dual MIT/Apache-2.0 license, allowing licensees to chose either at their option.

2 similar comments
@miwig
Copy link
Contributor

miwig commented Jul 1, 2024

I license past and future contributions to the rust-lang/rustc-perf repository under the dual MIT/Apache-2.0 license, allowing licensees to chose either at their option.

@tgnottingham
Copy link
Contributor

I license past and future contributions to the rust-lang/rustc-perf repository under the dual MIT/Apache-2.0 license, allowing licensees to chose either at their option.

@eddyb
Copy link
Member

eddyb commented Jul 2, 2024

I license past and future contributions to the rust-lang/rustc-perf repository under the dual MIT/Apache-2.0 license, allowing licensees to chose either at their option.

1 similar comment
@ecstatic-morse
Copy link
Contributor

I license past and future contributions to the rust-lang/rustc-perf repository under the dual MIT/Apache-2.0 license, allowing licensees to chose either at their option.

@Kobzol
Copy link
Contributor Author

Kobzol commented Jul 3, 2024

So, we got 30/31 approvals in 5 (!) days, that is awesome! Big thanks to everyone who expressed their approval.

The last remaining contributor who didn't express their approval yet, @Horki, contributed code that was since deleted and is no longer a part of this repository. Therefore I think that we should be good with moving forward with the licensing.

@Kobzol
Copy link
Contributor Author

Kobzol commented Jul 3, 2024

A top-level MIT license has been added: #1881.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests