Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

detailed-view: Add a "sum total" line at the top of the table. #525

Closed
michaelwoerister opened this issue Oct 23, 2019 · 3 comments
Closed

Comments

@michaelwoerister
Copy link
Member

michaelwoerister commented Oct 23, 2019

It would be helpful to have a line at the top of the table that shows the sum of the lines below, i.e. the total time spent in query providers/functions, the total number of query invocations, the total time spent in loading things from the incr. comp. cache, etc.

This is something that might be good to have to summarize in general. cc @wesleywiser

@michaelwoerister michaelwoerister changed the title detailed-view: Add a "sum total detailed-view: Add a "sum total" line at the top of the table. Oct 23, 2019
@michaelwoerister
Copy link
Member Author

@Mark-Simulacrum Could you somehow visually highlight the totals line? E.g. by making it bold or giving it a different background color.

@Mark-Simulacrum
Copy link
Member

We do italicize it today, I can try bolding it. Maybe adding an empty line after it would be good... but that seems pretty 'odd' too.

@wesleywiser
Copy link
Member

We could also make the background slightly darker:

image

#primary-table > tr:nth-child(1) {
  background-color: #EEE;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants