Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc build failed on 1.45.0 #696

Closed
Mark-Simulacrum opened this issue Jul 20, 2020 · 2 comments · Fixed by #697
Closed

Doc build failed on 1.45.0 #696

Mark-Simulacrum opened this issue Jul 20, 2020 · 2 comments · Fixed by #697

Comments

@Mark-Simulacrum
Copy link
Member

The beta run succeeded, but 1.45.0 was unable to be benchmarked. I suspect this is because of rust-lang/cargo#8449.

@Mark-Simulacrum
Copy link
Member Author

I'm inclined to just skip rustdoc perf collection for 1.45.0 entirely (probably a temporary patch in the code that does so), but wanted to file an issue in case people have other thoughts.

cc @jyn514

@jyn514
Copy link
Member

jyn514 commented Jul 20, 2020

Ah, I didn't realize you used the cargo from the release. Then yes, this will fail on all versions before rust-lang/cargo#8449 and after --document-private-items was added to cargo doc (not sure when that was).

You could still make it work by using the latest nightly cargo, but I don't know if that's worth the effort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants