-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docker-compose up -d --build
] + [cranelift] = [compilation error]
#1483
Comments
Can you post the full Dockerfile that fails for you? |
It looks like you are trying to use cg_clif on stable. It is currently only available on nightly. In addition you need to install the rustc-codegen-cranelift-preview component. I don't know if the container for rustc nightly has a way to install it, but if you were to use rustup, you did do |
I added your suggestions to my Dockerfile and it fixed it. Thanks 😄 Maybe you can add this in the README file? |
Happy to hear you managed to get it working! The nightly requirement and the need to install the rustc-codegen-cranelift-preview component is documented at https://github.com/rust-lang/rustc_codegen_cranelift#download-using-rustup Do you have any suggestions on how to make it clearer? |
Maybe create a Docker title in that README.md that explains the fact that you need to add
(or something like this) to Dockerfile in order for Docker to work with Cranelift. It's probably obvious to someone experienced with Docker, but Docker is something junior devs usually don't have mastery of (I'm late-junior or early-intermediate) so this is likely to be an issue many devs would stumble on if it isn't explicitly stated what needs to be put in Dockerfile to make it work with Docker. |
fwiw I think this isn't necessary to be documented in the readme, this is pretty obvious that to use cranelift in docker that it is necessary to use the same install steps as everywhere else. |
Cranelift is currently incompatible with the following Docker command (at least in my case):
docker-compose up -d --build
I get this error message:
Would be awesome if u fix it!
The text was updated successfully, but these errors were encountered: