Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the builtin import code #513

Open
antoyo opened this issue May 6, 2024 · 2 comments
Open

Remove the builtin import code #513

antoyo opened this issue May 6, 2024 · 2 comments

Comments

@antoyo
Copy link
Contributor

antoyo commented May 6, 2024

The builtin import code is a hack and it's starting to be an issue.
With the more recent compiler_builtins which implements the math builtin functions in Rust, we can get conflicts between the GCC imported builtins and the Rust builtins:

libgccjit.so: error: : gcc_jit_function_new_block: cannot add block to an imported function
thread 'rustc' panicked at /home/user/.cargo/git/checkouts/gccjit.rs-13c2e290f2fb9e4d/f1545d7/src/function.rs:183:17:
gcc_jit_function_new_block: cannot add block to an imported function (cos)
@g4titanx
Copy link
Contributor

if it's not being used anywhere else in the code, it shouldn't be a problem

@antoyo
Copy link
Contributor Author

antoyo commented May 23, 2024

Well, it's used in the sense that it's how we are able to return the Function object for builtin functions when requested elsewhere.
But having to list them all is not a good solution: I'd prefer something that would fetch the builtin only when requested.
Feel free to ask for more info in that's not clear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants