Better removal of UI tests with errors emitted by the frontend

[antoyo]

The test tests/ui/consts/const-eval/parse_ints.rs in the file failing-ui-tests.txt even though this is not something to fix on our end.

The reason it is not removed is because the test file doesn't contain any error pattern like //@ error-pattern: and we only remove tests containing those patterns.
According to the documentation, a UI test is expected to generate a compile error by default, so perhaps we should only keep the tests with one of the pass headers:

• //@ check-pass
• //@ build-pass
• //@ run-pass

[badumbatish]

hi! i want to start partcipating in rustc_codegen_gcc, for this task does this mean i need to go through every file in the failing-ui-tests.txt and only include the files that have //@ check-pass , //@ build-pass or //@ run-pass ?

[antoyo]

Sorry, I was on vacation and I missed this.

Yes, you'll kind of need to invert the logic here to check for these patterns indeed.

[ibilalkayy]

@antoyo Here is the PR that I sent and it solves this problem.