-
Notifications
You must be signed in to change notification settings - Fork 898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tracking issue: CI support #2614
Comments
The versioning issue is that as Rustfmt evolves, the formatting will change and thus by running One step towards fixing this is to specify the Rustfmt version in the rustfmt.toml. Then emit a specific error if the versions don't match. This doesn't solve the problem, but it does make the problem explicit, rather than being a confusing, hard to fix error. This might be sufficient for 1.0, together with a strict channel system to ensure that formatting changes rarely. |
Versioning issue can be solved by |
Ideally we'd have a solution that worked for Rustup without having to rebuild from source. Though it might be that we just have to accept building from source (the problem of course being if the user is on a stable toolchain because we use unstable features). On Rustup, it is difficult because we're closely tied to the compiler version (although not too closely, nowadays). |
Perhaps we could have a story including only the diffs (and using rustfmt-format-diff). Apparently this is the Chrome/clang-format strategy. |
Versioning is discussed in rust-lang/rfcs#2437 |
RFC 2437 is in FCP, so I believe this issue is complete (we still need to implement versioning, but that can come later). |
A key use case for Rustfmt is running on CI. A key part of that is the new
check
write mode. There are other issues too though.check
write mode (Tracking issue:check
write mode follow-up #2536, Implemented rough draft ofcheck
write mode. #2539)The text was updated successfully, but these errors were encountered: