Skip to content

Update usage of deprecated GitHub Actions Commands #4480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
calebcartwright opened this issue Oct 20, 2020 · 3 comments
Closed

Update usage of deprecated GitHub Actions Commands #4480

calebcartwright opened this issue Oct 20, 2020 · 3 comments
Labels
good first issue Issues up for grabs, also good candidates for new rustfmt contributors hacktoberfest help wanted

Comments

@calebcartwright
Copy link
Member

(At least) One of our GHA workflows is still leveraging the deprecated ::add::path command, and this needs to be converted to the new model.

The one place I know we're using this for sure is in the Windows i686-pc-windows-gnu job though there may be others.

Reference PR from rustup where similar updates were made:
rust-lang/rustup#2513
@calebcartwright calebcartwright added good first issue Issues up for grabs, also good candidates for new rustfmt contributors help wanted hacktoberfest labels Oct 20, 2020
@srinikhil-07
Copy link
Contributor

@calebcartwright

I would like to fix this issue.

@calebcartwright
Copy link
Member Author

Excellent, thanks @Nikhil0487!

@srinikhil-07 srinikhil-07 mentioned this issue Oct 28, 2020
Merged
@calebcartwright
Copy link
Member Author

Closed via #4497

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Issues up for grabs, also good candidates for new rustfmt contributors hacktoberfest help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@calebcartwright @srinikhil-07