Skip to content

Rustfmt is removing comments #4541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
GuillaumeGomez opened this issue Nov 22, 2020 · 3 comments
Closed

Rustfmt is removing comments #4541

GuillaumeGomez opened this issue Nov 22, 2020 · 3 comments
Labels
bug Panic, non-idempotency, invalid code, etc. duplicate

Comments

@GuillaumeGomez
Copy link
Member

A good example:

$ cargo fmt
$ git diff
git diff
diff --git a/atk/sys/src/lib.rs b/atk/sys/src/lib.rs
index bce5341b6..9f32aab56 100644
--- a/atk/sys/src/lib.rs
+++ b/atk/sys/src/lib.rs
@@ -1761,10 +1761,6 @@ impl ::std::fmt::Debug for AtkWindow {
 
 #[link(name = "atk-1.0")]
 extern "C" {
-
-    //=========================================================================
-    // AtkCoordType
-    //=========================================================================
     pub fn atk_coord_type_get_type() -> GType;
 
     //=========================================================================
diff --git a/gdk-pixbuf/sys/src/lib.rs b/gdk-pixbuf/sys/src/lib.rs
index 67d190558..9d7b5ebc8 100644
--- a/gdk-pixbuf/sys/src/lib.rs
+++ b/gdk-pixbuf/sys/src/lib.rs
@@ -166,10 +166,6 @@ impl ::std::fmt::Debug for GdkPixbufSimpleAnimIter {
 
 #[link(name = "gdk_pixbuf-2.0")]
 extern "C" {
-
-    //=========================================================================
-    // GdkColorspace
-    //=========================================================================
     pub fn gdk_colorspace_get_type() -> GType;
 
     //=========================================================================
diff --git a/gdk/sys/src/lib.rs b/gdk/sys/src/lib.rs
index 26e5cee34..9fa1dcd15 100644
--- a/gdk/sys/src/lib.rs
+++ b/gdk/sys/src/lib.rs
@@ -4088,10 +4088,6 @@ impl ::std::fmt::Debug for GdkDevicePad {
 
 #[link(name = "gdk-3")]
 extern "C" {
-
-    //=========================================================================
-    // GdkAxisUse
-    //=========================================================================
     pub fn gdk_axis_use_get_type() -> GType;
 
     //=========================================================================
diff --git a/gdkx11/sys/src/lib.rs b/gdkx11/sys/src/lib.rs
index 6518a3a4d..59c5b4b5d 100644
--- a/gdkx11/sys/src/lib.rs
+++ b/gdkx11/sys/src/lib.rs
@@ -255,10 +255,6 @@ impl ::std::fmt::Debug for GdkX11Window {
 
 #[link(name = "gdk-3")]

From the repository https://github.com/gtk-rs/gtk-rs

@GuillaumeGomez GuillaumeGomez added the bug Panic, non-idempotency, invalid code, etc. label Nov 22, 2020
@calebcartwright
Copy link
Member

Guessing this is a duplicate of #4528, which version of rustfmt are you using?

@GuillaumeGomez
Copy link
Member Author

This one:

$ rustfmt --version
rustfmt 1.4.26-nightly (293d7d0 2020-11-14)

@calebcartwright
Copy link
Member

Yup, duplicate of #4528 so going to close. It's resolved in 1.4.27 which is available on nightly already (starting on 2020-11-17 IIRC)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Panic, non-idempotency, invalid code, etc. duplicate
Projects
None yet
Development

No branches or pull requests

2 participants