Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Would backport of chain_width to 1.4.x be considered? #4769

Closed
ctz opened this issue Mar 27, 2021 · 6 comments
Closed

Would backport of chain_width to 1.4.x be considered? #4769

ctz opened this issue Mar 27, 2021 · 6 comments

Comments

@ctz
Copy link
Contributor

ctz commented Mar 27, 2021

Hello,

Thank you for your work on rustfmt!

Over in rustls we're using rustfmt 2.0 (built from source), because we're using the chain_width option reintroduced in this version. I've read in #4582 the issues with releasing/stabilising 2.0, and these seem clear to me.

However, would the maintainers accept a PR that backported support for chain_width to the 1.4 release line?

Thanks,
Joe

@calebcartwright
Copy link
Member

Absolutely! I was actually already planning to backport the changes that made the granular *_width options (includes chain_width) public and available to users.

Doing so is second on my rustfmt code/development to-do list, though most of my bandwidth these days is preoccupied with the typical admin/support/maintenance/etc. work so not sure exactly when I'd be able to get around to it myself.

PRs are always appreciated as well, but this is definitely something that will get done either way.

@InsertCreativityHere
Copy link

Hey there @ctz!
I was wondering if you were going forward with your PR, because otherwise I was going to write one myself!
I'm in the same boat as you, building 2.0 from source to get chain_width and fn_call_width, and it would be real nice to have it in 1.4.x instead! 😄

@calebcartwright calebcartwright added 1x-backport:pending Fixed/resolved in source but not yet backported to a 1x branch and release and removed feature-request labels Apr 8, 2021
@calebcartwright calebcartwright added this to the 1.4.38 milestone Apr 8, 2021
@karyon
Copy link
Contributor

karyon commented Oct 22, 2021

@calebcartwright after #4782 has been merged, is there anything left to do here?

@ctz
Copy link
Contributor Author

ctz commented Oct 22, 2021

This was done, merged and was released.

@ctz ctz closed this as completed Oct 22, 2021
@karyon
Copy link
Contributor

karyon commented Oct 25, 2021

(I think the last release 1.4.37 was done before the backport was merged, so it's not released yet)

@karyon karyon added 1x-backport:completed and removed 1x-backport:pending Fixed/resolved in source but not yet backported to a 1x branch and release labels Oct 25, 2021
@calebcartwright
Copy link
Member

(I think the last release 1.4.37 was done before the backport was merged, so it's not released yet)

I forget the exact path it took to get there, but this was one that got deployed a while ago (has been around since Rust v1.53). Either way, backport definitely completed 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants