-
Notifications
You must be signed in to change notification settings - Fork 888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Would backport of chain_width to 1.4.x be considered? #4769
Comments
Absolutely! I was actually already planning to backport the changes that made the granular Doing so is second on my rustfmt code/development to-do list, though most of my bandwidth these days is preoccupied with the typical admin/support/maintenance/etc. work so not sure exactly when I'd be able to get around to it myself. PRs are always appreciated as well, but this is definitely something that will get done either way. |
Hey there @ctz! |
@calebcartwright after #4782 has been merged, is there anything left to do here? |
This was done, merged and was released. |
(I think the last release 1.4.37 was done before the backport was merged, so it's not released yet) |
I forget the exact path it took to get there, but this was one that got deployed a while ago (has been around since Rust v1.53). Either way, backport definitely completed 😁 |
Hello,
Thank you for your work on rustfmt!
Over in rustls we're using rustfmt 2.0 (built from source), because we're using the
chain_width
option reintroduced in this version. I've read in #4582 the issues with releasing/stabilising 2.0, and these seem clear to me.However, would the maintainers accept a PR that backported support for
chain_width
to the 1.4 release line?Thanks,
Joe
The text was updated successfully, but these errors were encountered: