Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please show even more dates #36

Open
Timmmm opened this issue Jun 30, 2021 · 5 comments
Open

Please show even more dates #36

Timmmm opened this issue Jun 30, 2021 · 5 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Timmmm
Copy link

Timmmm commented Jun 30, 2021

Related to #1 - it would be nice if this showed more than a week! I want to go a few months back.

@mexus
Copy link
Contributor

mexus commented Jun 30, 2021

Well, we can definitely increase the amount of days displayed, but current design of the history page won't work well with too many days (and "a few months" is quite a lot), so we gonna need a help to make a more.. scalable view.

Could you please describe more specifically which problem are you trying to solve? Maybe we could find an easier solution? For instance, we've got a "json" interface (like https://rust-lang.github.io/rustup-components-history/x86_64-unknown-linux-gnu/miri.json) apart from the html one, currently they basically provide the same amount of information, but I guess it's way simpler to expand those jsons to have more dates. Could it work for you?

@Timmmm
Copy link
Author

Timmmm commented Jun 30, 2021

The specific problem I was trying to solve was to install a nightly from a few months ago. I tried a random day but it didn't work because rustfmt was missing. I came here hoping to easily see the nearest build that had all of the components.

I ended up just trying each day until one worked, but that obviously sucks.

but current design of the history page won't work well with too many days

Yeah I think it could be made to work fairly easily. Here are some options:

  1. Add "previous week" / "next week" buttons.
  2. Just use horizontal scrolling.
  3. Transpose the table and use vertical scrolling.

I would probably go with option 3 if it were me.

@mexus mexus added enhancement New feature or request good first issue Good for newcomers labels Jun 30, 2021
@mexus
Copy link
Contributor

mexus commented Jun 30, 2021

I suppose it must be not that hard to try out both 2 and 3 variants and decide which one will do a better job. Implementing the first suggestion will either require a runtime on the page and/or severe changes to the core rust code, so let's no consider it for now.

I'm not quite sure though when I have time to work on the issue, but I'll do my best to find an hour or two before the weekend to test things out

@Timmmm
Copy link
Author

Timmmm commented Jul 1, 2021

No rush! It was more of a wishlist thing. :-)

@PrismaPhonic
Copy link

PrismaPhonic commented Aug 9, 2021

What I would like is a way to search from a date in history the most recent nightly after that date that has all componenets.

The issue we are facing is when we need to update nightly to get fixes in, and accidentally pick a nightly that is missing one necessary component. To fix this we don't want to push forward to newest nightly and potentially introduce breakages. Instead it would be nice to find the most recent nightly from where we are at that has all components to minimize the likelihood of new breaking changes.

And it would be nice if this was available regardless of how far in the past we are with our current nightly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants