Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gracefully handle renamed components when updating toolchains #1546

Closed
alexcrichton opened this issue Nov 19, 2018 · 3 comments
Closed

Gracefully handle renamed components when updating toolchains #1546

alexcrichton opened this issue Nov 19, 2018 · 3 comments

Comments

@alexcrichton
Copy link
Member

In some local testing when we rename a component (for example from rls-preview to rls) then if the component is previously installed whenever you update it'll uninstall rls-preview but fail to install rls shortly afterwards.

This is likely a local regression in rustup from some time ago, but it's unsure where just yet!

Once this is fixed and propagated enough in rustup then we can switch the actual names in the released manifests from rls-preview to rls and such.
@alexcrichton
Copy link
Member Author

cc @nrc

@alexcrichton alexcrichton mentioned this issue Nov 19, 2018
Closed
2 tasks
@nrc nrc mentioned this issue Nov 21, 2018
Merged
@kinnison
Copy link
Contributor

kinnison commented Jan 8, 2019

Does this need to remain open or was it resolved by #1549 ? If it's not resolved then what remains to-do?

@kinnison
Copy link
Contributor

I'm assuming this is all done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexcrichton @kinnison