Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

illumos rustup-init binary seems to be missing from the main server #2580

Closed
jclulow opened this issue Nov 27, 2020 · 5 comments
Closed

illumos rustup-init binary seems to be missing from the main server #2580

jclulow opened this issue Nov 27, 2020 · 5 comments
Labels
bug fixed-next-release This issue will be fixed in the next release of rustup.
Milestone

Comments

@jclulow
Copy link
Contributor

jclulow commented Nov 27, 2020

I believe the latest rustup version should support illumos systems, as my patch for that was integrated into the main branch a little while ago now. Unfortunately it doesn't seem like the rustup-init binary has made it to the right place:

$ uname -so
SunOS illumos

$ curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | bash
info: downloading installer
curl: (22) The requested URL returned error: 404
rustup: command failed: downloader https://static.rust-lang.org/rustup/dist/x86_64-unknown-illumos/rustup-init /tmp/tmp.8JaGWv/rustup-init x86_64-unknown-illumos

It seems like I must have missed something in my change for that. Is there some way we can get the binary built? Is there a build error log I should be looking at?

Cheers.

@jclulow jclulow added the bug label Nov 27, 2020
@kinnison
Copy link
Contributor

Irritatingly it looks like Illumos being built on stable was missed from this release (the workflow files missed it somehow).

I've ensured that won't happen in the future, and I'll see if there's a way we can get a build uploaded for 1.23.0.

@kinnison
Copy link
Contributor

@pietroalbini If I push the updated workflow file to the stable branch so that it builds the illumos binary, can we get that pushed onto static.rlo?

@kinnison
Copy link
Contributor

I'm looking at a potential need for a 1.23.1 to deal with a snafu in the macos builds which nobody spotted in the testing week, so I'll target this to there.

@kinnison kinnison added this to the 1.23.1 milestone Nov 29, 2020
@kinnison kinnison added the fixed-next-release This issue will be fixed in the next release of rustup. label Nov 29, 2020
@jclulow
Copy link
Contributor Author

jclulow commented Nov 30, 2020

Thanks for looking into it!

@kinnison
Copy link
Contributor

kinnison commented Dec 1, 2020

This should now be live.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fixed-next-release This issue will be fixed in the next release of rustup.
Projects
None yet
Development

No branches or pull requests

2 participants