Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Non-unicode values of HKCU\Environment\PATH are not handled #265

Closed
brson opened this issue Apr 5, 2016 · 2 comments · Fixed by #2649
Closed

Non-unicode values of HKCU\Environment\PATH are not handled #265

brson opened this issue Apr 5, 2016 · 2 comments · Fixed by #2649
Labels
bug help wanted

Comments

@brson
Copy link
Contributor

brson commented Apr 5, 2016

This registry key is modified on install and uninstall. If it contains a non-unicode value rustup will panic.
@brson brson mentioned this issue Apr 5, 2016
Merged
@brson
Copy link
Contributor Author

brson commented Apr 5, 2016

Oh, it's actually worse than that. rustup deletes the PATH value of it's non-unicode...

@brson
Copy link
Contributor Author

brson commented Apr 6, 2016

After the above patch we print a warning and don't mess with it. Would be better still to handle non-unicode correctly with OsStrings.

@kellda kellda mentioned this issue Feb 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Handle PATHs with non-unicodes values on Windows kellda/rustup
2 participants
@brson @Diggsey