Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect dead code better #2730

Closed
rbtcollins opened this issue Apr 23, 2021 · 4 comments
Closed

Detect dead code better #2730

rbtcollins opened this issue Apr 23, 2021 · 4 comments
Labels
E-easy enhancement help wanted

Comments

@rbtcollins
Copy link
Contributor

rbtcollins commented Apr 23, 2021 •
edited by rustbot
Loading

We should stop using 'pub' and instead use 'crate' within rustup. Rustup has no exported API, but having pub functions results in dead types and functions not being detected. rust-lang/rust#79061 is an example of this technique applied to rustdoc
@Rustin170506
Copy link
Member

I am working on this.

This was referenced Apr 26, 2021
Closed
Merged
@Rustin170506 Rustin170506 mentioned this issue May 5, 2021
Merged
@Rustin170506
Copy link
Member

@rustbot claim

@Rustin170506 Rustin170506 mentioned this issue May 31, 2021
Merged
@Rustin170506
Copy link
Member

  • After most of the cleanup is done, we should globally introduce #! [deny(unreachable_pub)].

@Rustin170506 Rustin170506 mentioned this issue Jun 26, 2021
Merged
@Rustin170506 Rustin170506 mentioned this issue Jul 19, 2021
Merged
@Rustin170506 Rustin170506 mentioned this issue Nov 14, 2021
Closed
@Rustin170506 Rustin170506 removed their assignment Jan 1, 2022
@Rustin170506
Copy link
Member

I think we can close it now. It's done.

@kinnison kinnison closed this as completed Jan 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
E-easy enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

globally introduce #![deny(unreachable_pub)] Rustin170506/rustup
3 participants
@rbtcollins @kinnison @Rustin170506