Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reserve RUSTUP_LOG for tracing usages instead of RUST_LOG #3875

Closed
Tracked by #3790
rami3l opened this issue Jun 15, 2024 · 1 comment · Fixed by #3876
Closed
Tracked by #3790

Reserve RUSTUP_LOG for tracing usages instead of RUST_LOG #3875

rami3l opened this issue Jun 15, 2024 · 1 comment · Fixed by #3876
Milestone

Comments

@rami3l
Copy link
Member

rami3l commented Jun 15, 2024

Problem you are trying to solve

@weihanglo has raised concerns regarding RUST_LOG adding Rustup's log lines to cargo run when cargo is a rustup shim.

Cargo has changed to using CARGO_LOG for cargo-internal log lines for clarity in rust-lang/cargo#6918, and considering the special relationship between the two projects, I think it's reasonable for us to do the same.

Solution you'd like

Reserve RUSTUP_LOG for tracing usages inside of Rustup instead of the default RUST_LOG.

Notes

No response

@djc
Copy link
Contributor

djc commented Jun 15, 2024

Yup, this makes sense to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants