Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustup toolchain documentation mentions uninstall, code expects remove #465

Closed
iliekturtles opened this issue May 14, 2016 · 1 comment
Closed

Comments

@iliekturtles
Copy link

Running rustup toolchain displays

$ rustup toolchain
rustup.exe-toolchain
Modify or query the installed toolchains

USAGE:
    rustup.exe toolchain [FLAGS] [SUBCOMMAND]

FLAGS:
    -h, --help    Prints help information

SUBCOMMANDS:
    list         List installed toolchains
    install      Install or update a given toolchain
    uninstall    Uninstall a toolchain
...

However running rustup toolchain uninstall nightly fails

$ rustup toolchain uninstall nightly
thread '<main>' panicked at 'internal error: entered unreachable code', src/rustup-cli\rustup_mode.rs:42
note: Run with `RUST_BACKTRACE=1` for a backtrace.

Documentation (https://github.com/rust-lang-nursery/rustup.rs/blob/8838957d197df31f43582393084f6b43ec18db58/src/rustup-cli/rustup_mode.rs#L138) says the command is uninstall but parsing code expects remove (https://github.com/rust-lang-nursery/rustup.rs/blob/8838957d197df31f43582393084f6b43ec18db58/src/rustup-cli/rustup_mode.rs#L34).

I would expect install/uninstall to be the main commands and remove to be the synonym. If this is the case (and I linked to the appropriate locations) I will work on submitting a PR this week.

@iliekturtles
Copy link
Author

Fixed by 3f2f854 (#474).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant