Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reenable anti-sudo check #699

Closed
brson opened this issue Aug 28, 2016 · 2 comments
Closed

Reenable anti-sudo check #699

brson opened this issue Aug 28, 2016 · 2 comments

Comments

@brson
Copy link
Contributor

brson commented Aug 28, 2016

Disabled because it's being miscompiled. #698
@inejge
Copy link
Contributor

inejge commented Aug 31, 2016 •
edited
Loading

Is there a known distro/nightly/rustup commit combination that produces a crashing rustup-init for 64-bit Linux? I tried with nightly-2016-08-21 and rustup pre-0.6.2 on CentOS 6, but couldn't get a segfault.

Edit: NVM, found the relevant issues. The interesting thing is that in my testing I don't get a segfault in every run. I thought I could rework the sudo check code to avoid the bug, but on further inspection it seems unlikely.

Does reenabling the check include reverting the changes to .travis.yml and appveyor.yml, or that should go into a separate PR?

@kinnison kinnison mentioned this issue Jan 2, 2020
Merged
@kinnison
Copy link
Contributor

kinnison commented Jan 5, 2020

This looks to have been reenabled in e308c56

@kinnison kinnison closed this as completed Jan 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@brson @inejge @kinnison