New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blocking issues on master #244

Closed

Thomasdezeeuw opened this issue Jun 8, 2021 · 0 comments · Fixed by #253

Collaborator

Thomasdezeeuw commented Jun 8, 2021

This is mostly a note to myself.

These are blocking issue for a new release, either v0.4.x or v0.5, that are currently on master.

After pr Allow for niche optimization on Unix platforms #222 was merged issue SockRef::from, Socket::sendfile and other functions that operate on arbitrary file descriptors or SOCKETs potentially should be unsafe #218 was made even worse as issue Unsoundness in <SockRef as From<&AsRawFd>>::from #229 shows. Either Allow for niche optimization on Unix platforms #222 must be reverted or SockRef::from, Socket::sendfile and other functions that operate on arbitrary file descriptors or SOCKETs potentially should be unsafe #218 solved before another release.

The text was updated successfully, but these errors were encountered:

Thomasdezeeuw mentioned this issue

Assert validity on the raw socket in SockRef::from #253

Merged

Thomasdezeeuw closed this as completed in #253

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment